Fix traditional repeated reverse isearch when not using fzf #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when not using fzf. According to * https://github.com/prompt-toolkit/python-prompt-toolkit/blob/3374ae9dd56f0265b41022e81341fd062092e2f0/src/prompt_toolkit/key_binding/bindings/search.py#L47-L53 it looks like we need to set the "control_is_searchable" filter in order to map control-r (and escape-r) only when _outside_ the isearch mini-mode keymap. It isn't clear how to specify both emacs_mode and control_is_searchable as filters, so emacs_mode was removed. Closes #1310.
amjith
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to
it looks like we need to set the
control_is_searchablefilter in order to map control-r (and escape-r) only when outside the isearch mini-mode keymap.It isn't clear how to specify both
emacs_modeandcontrol_is_searchableas filters, soemacs_modewas removed.Closes #1310.
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff formatto lint and format the code.