这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix traditional repeated reverse isearch when not using fzf #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Fix traditional repeated reverse isearch when not using fzf #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Upcoming Release (TBD)
Bug Fixes
--------
* Improve missing ssh-extras message.
* Fix repeated control-r in traditional reverse isearch.


Internal
Expand Down
6 changes: 3 additions & 3 deletions mycli/key_bindings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import logging

from prompt_toolkit.enums import EditingMode
from prompt_toolkit.filters import completion_is_selected, emacs_mode
from prompt_toolkit.filters import completion_is_selected, control_is_searchable, emacs_mode
from prompt_toolkit.key_binding import KeyBindings
from prompt_toolkit.key_binding.key_processor import KeyPressEvent

Expand Down Expand Up @@ -140,7 +140,7 @@ def _(event: KeyPressEvent) -> None:

event.app.current_buffer.insert_text(shortcuts.server_datetime(mycli.sqlexecute, quoted=True))

@kb.add("c-r", filter=emacs_mode)
@kb.add("c-r", filter=control_is_searchable)
def _(event: KeyPressEvent) -> None:
"""Search history using fzf or reverse incremental search."""
_logger.debug("Detected <C-r> key.")
Expand All @@ -150,7 +150,7 @@ def _(event: KeyPressEvent) -> None:
else:
search_history(event)

@kb.add("escape", "r", filter=emacs_mode)
@kb.add("escape", "r", filter=control_is_searchable)
def _(event: KeyPressEvent) -> None:
"""Search history using fzf when available."""
_logger.debug("Detected <alt-r> key.")
Expand Down