fix: linter issues #842
Merged
fix: linter issues #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes linter errors by cleaning up imports and tightening test assertions to prevent the broken build.
- Swapped
assert.NoErrorforrequire.NoErrorin tests for early test exit on error. - Removed unused
fmtimport and replacedfmt.Errorfwitherrors.Newin core code.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| autopatch/autopatch_test.go | Replaced assert.NoError with require.NoError and added import |
| autopatch/autopatch.go | Changed error creation to errors.New and removed fmt import |
| result, err := replaceNulls([]byte(tc.input), settings) | ||
| assert.NoError(t, err) | ||
| require.NoError(t, err) | ||
| assert.JSONEq(t, tc.expected, string(result)) |
There was a problem hiding this comment.
[nitpick] Since you're using require.NoError to fail fast, consider switching assert.JSONEq to require.JSONEq for consistency and immediate failure on JSON mismatches.
Suggested change
| assert.JSONEq(t, tc.expected, string(result)) | |
| require.JSONEq(t, tc.expected, string(result)) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 93.08% 93.04% -0.05%
==========================================
Files 23 23
Lines 5307 5390 +83
==========================================
+ Hits 4940 5015 +75
- Misses 314 319 +5
- Partials 53 56 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the broken build.