fix: linter issues #842
fix: linter issues #842
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes linter errors by cleaning up imports and tightening test assertions to prevent the broken build.
- Swapped
assert.NoErrorforrequire.NoErrorin tests for early test exit on error. - Removed unused
fmtimport and replacedfmt.Errorfwitherrors.Newin core code.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| autopatch/autopatch_test.go | Replaced assert.NoError with require.NoError and added import |
| autopatch/autopatch.go | Changed error creation to errors.New and removed fmt import |
| @@ -520,7 +521,7 @@ func TestReplaceNulls(t *testing.T) { | |||
| for _, tc := range tests { | |||
| t.Run(tc.name, func(t *testing.T) { | |||
| result, err := replaceNulls([]byte(tc.input), settings) | |||
| assert.NoError(t, err) | |||
| require.NoError(t, err) | |||
| assert.JSONEq(t, tc.expected, string(result)) | |||
There was a problem hiding this comment.
[nitpick] Since you're using require.NoError to fail fast, consider switching assert.JSONEq to require.JSONEq for consistency and immediate failure on JSON mismatches.
| assert.JSONEq(t, tc.expected, string(result)) | |
| require.JSONEq(t, tc.expected, string(result)) |
Copilot uses AI. Check for mistakes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 93.08% 93.04% -0.05%
==========================================
Files 23 23
Lines 5307 5390 +83
==========================================
+ Hits 4940 5015 +75
- Misses 314 319 +5
- Partials 53 56 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This should fix the broken build.