这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@phreed
Copy link
Contributor

@phreed phreed commented Feb 27, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.

When in trouble, please check our knowledge base documentation before pinging a team.

In order to address the issue of vendoring other packages this package is waiting on the following packages:

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mumble/recipe.yaml) and found it was in an excellent condition.

@phreed
Copy link
Contributor Author

phreed commented Feb 27, 2025

@conda-forge/help-c-cpp ready for review.
I have some known issues for which I would like guidance:

CMake Error at CMakeLists.txt:58 (include):
 │ │   include could not find requested file:
 │ │     FindPythonInterpreter

I included python as a build dependency, I thought that would fix this issue but it does not.

This package has dependencies which do not have conda-forge packages.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 20, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mumble-voip/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/mumble-voip/recipe.yaml:

For recipes/mumble-voip/recipe.yaml:

  • ℹ️ The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.
  • ℹ️ The abseil-cpp output has been superseded by libabseil.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17111969788. Examine the logs at this URL for more detail.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • .gitignore:
    • lints:
      • Do not edit files outside of the recipes/ directory.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mumble-voip/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mumble-voip/recipe.yaml:

  • ℹ️ The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.
  • ℹ️ The abseil-cpp output has been superseded by libabseil.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17128071629. Examine the logs at this URL for more detail.

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@danielnachun
Copy link
Contributor

This recipe is currently very complicated and has a lot of unnecessary content that needs to be cleaned up before it can be merged.

A few changes to start off with:

  • You are setting many values in variants.yaml which are already the default values in conda-forge-pinning. We don't want to set these values manually unless they must be a non-default value. The only value that will probably need to be set manually is MACOSX_SDK_VERSION.
  • You should not normally need to set c_stdlib_version on macOS for C++ programs - instead you need to add -D_LIBCPP_DISABLE_AVAILABILITY to the CXXFLAGS and make sure MACOSX_SDK_VERSION is set to the required OS minimum.
  • You are trying skip using conda-forge supplied compilers on macOS, which is not permitted. Instead of doing this, we need to figure out why the build isn't working with our compilers and fix that instead, even if it requires patching. Right now I suspect your problems are originating from the typical issues with targeting a newer libc++ on an older macOS, which can usually be solved with the above fix I have suggested.
  • The recipe is too long to have the build script embedded in it. Please put the build script in a separate file.
  • While I appreciate your effort to try to use nushell to get a single build script for both OSes, I'm afraid it adds quite a bit of unnecessary complexity to the logic. Most CMake projects only require a relatively small number of commands to run so it is not difficult to implement these as separate bash and batch scripts.
  • You are vendoring package with stable versions in the recipe. When a stable version can be used, it is preferable to patch the CMake file to use the "system" version rather than rebuilding the same package again.
  • For the vendored dependencies which are not from stable versions, their licenses must be included in the recipe.

I'm also happy to try to push some commits for this as I think the whole recipe can be greatly simplified and that will make it much easier to review some of the trickier issues.

@phreed phreed marked this pull request as draft August 29, 2025 18:15
@phreed
Copy link
Contributor Author

phreed commented Aug 29, 2025

I was not sure what to do with the vendoring.
The source is working with copies of the dependencies.
As I am not sure if those copies were modified, I included them as well.
I thought I had included the licenses properly but maybe not.

@phreed
Copy link
Contributor Author

phreed commented Aug 29, 2025

I have made a PR for the patches

I'm also happy to try to push some commits for this as I think the whole recipe can be greatly simplified and that will make it much easier to review some of the trickier issues.

If it is all the same to you I would like to try to get this in shape with your guidance as a learning exercise.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mumble-voip/recipe.yaml, recipes/microsoft-gsl/recipe.yaml, recipes/tracy-profiler/recipe.yaml, recipes/speexdsp/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/mumble-voip/recipe.yaml:

For recipes/microsoft-gsl/recipe.yaml:

For recipes/tracy-profiler/recipe.yaml:

For recipes/speexdsp/recipe.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17336163298. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 29, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/microsoft-gsl/recipe.yaml, recipes/mumble-voip/recipe.yaml, recipes/tracy-profiler/recipe.yaml, recipes/speexdsp/recipe.yaml) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • recipes/example-v1/recipe.yaml:
    • lints:
      • Do not edit or delete example recipes in recipes/example/ or recipe/example-v1/.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Sep 8, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mumble-voip/recipe.yaml, recipes/speexdsp/recipe.yaml, recipes/tracy-profiler/recipe.yaml, recipes/microsoft-gsl/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/mumble-voip/recipe.yaml:

For recipes/mumble-voip/recipe.yaml:

  • ℹ️ libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("cxx") }}

For recipes/speexdsp/recipe.yaml:

For recipes/speexdsp/recipe.yaml:

  • ℹ️ Use of posix package on windows is deprecated. Use m2-base.
  • ℹ️ libgcc-ng has been superseded by libgcc. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("c") }} and {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("c") }}    # depending on which...
        - {{ compiler("cxx") }}  # ... compilers you use
  • ℹ️ libstdcxx-ng has been superseded by libstdcxx. Note however, that except in truly exceptional cases, you should not have to add this manually; you can rely on the fact that {{ compiler("cxx") }} will always create the correct run-export for this. If you need to ignore the run-export for whatever reason, the best way to do it is:
    build:
      ignore_run_exports_from:
        - {{ compiler("cxx") }}

For recipes/tracy-profiler/recipe.yaml:

For recipes/microsoft-gsl/recipe.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19379032191. Examine the logs at this URL for more detail.

@phreed
Copy link
Contributor Author

phreed commented Sep 9, 2025

This mumble system typically bundles (vendors) several packages.
This is not the conda-forge way.
To that end I am presenting another set of staged-recipes which are those packages upon which mumble depends.

#31004

Until those are properly assigned feedstocks I will keep this package as a draft.

@phreed
Copy link
Contributor Author

phreed commented Sep 9, 2025

@conda-forge-admin retract review request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants