-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding the Mumble voip package #29311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-c-cpp ready for review. I included This package has dependencies which do not have conda-forge packages. |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mumble-voip/recipe.yaml:
For recipes/mumble-voip/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17111969788. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and I found some lint. It looks like some changes were made outside the If these changes are intentional (and you aren't submitting a recipe), please add a File-specific lints and/or hints:
|
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/mumble-voip/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17128071629. Examine the logs at this URL for more detail. |
|
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
|
This recipe is currently very complicated and has a lot of unnecessary content that needs to be cleaned up before it can be merged. A few changes to start off with:
I'm also happy to try to push some commits for this as I think the whole recipe can be greatly simplified and that will make it much easier to review some of the trickier issues. |
|
I was not sure what to do with the vendoring. |
|
I have made a PR for the patches
If it is all the same to you I would like to try to get this in shape with your guidance as a learning exercise. |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mumble-voip/recipe.yaml:
For recipes/microsoft-gsl/recipe.yaml:
For recipes/tracy-profiler/recipe.yaml:
For recipes/speexdsp/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17336163298. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the staged-recipes linter and I found some lint. It looks like some changes were made outside the If these changes are intentional (and you aren't submitting a recipe), please add a File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mumble-voip/recipe.yaml:
For recipes/mumble-voip/recipe.yaml:
For recipes/speexdsp/recipe.yaml:
For recipes/speexdsp/recipe.yaml:
For recipes/tracy-profiler/recipe.yaml:
For recipes/microsoft-gsl/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19379032191. Examine the logs at this URL for more detail. |
|
This mumble system typically bundles (vendors) several packages. Until those are properly assigned feedstocks I will keep this package as a draft. |
|
@conda-forge-admin retract review request |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).When in trouble, please check our knowledge base documentation before pinging a team.
In order to address the issue of vendoring other packages this package is waiting on the following packages:
minhooka Mumble dependency package #31483microsoft-gsla Mumble dependency package #31484speexdspa Mumble dependency package #31485spscqueuea Mumble dependency package #31486tracy-profilera Mumble (a voip system) dependency #31004