Add minhook a Mumble dependency package
#31483
Conversation
This commit introduces individual conda recipes for Mumble's core dependencies: - microsoft-gsl: Microsoft Guidelines Support Library - minhook: Minimalistic x86/x64 API hooking library - speexdsp: Speex audio codec DSP library - spscqueue: Single Producer Single Consumer queue - tracy-profiler: Real-time, nanosecond resolution frame profiler Each package includes: - Complete recipe.yaml with proper dependency specifications - Cross-platform build scripts (build.nu using Nushell) - Platform-specific configurations and variants - Comprehensive documentation and testing These recipes replace the previous monolithic Mumble build approach and enable better dependency management and individual package updates. Built and tested on Linux, Windows, and macOS platforms.
…into mumble-deps
This is what is expected of a conda-forge package.
- Use forward slashes consistently for CMAKE_INSTALL_PREFIX on Windows - Remove absolute paths for CMAKE_INSTALL_*DIR variables to let CMake handle them relative to prefix - Convert backslashes to forward slashes in prefix paths to avoid escape sequence issues in cmake_install.cmake - Affects: microsoft-gsl, speexdsp, minhook, spscqueue, tracy-profiler recipes
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-c-cpp, ready for review |
| Version 1.3.4 brings significant improvements including better build system | ||
| support, enhanced error handling, and broader compiler compatibility. |
There was a problem hiding this comment.
I am not sure if it make sense to have version-specific comments on the description.
| if ($nu.os-info.name == "windows") { | ||
| let lib_dir = ($env.PREFIX | path join "Library" "lib") | ||
| let x64_lib = ($lib_dir | path join "minhook.x64.lib") | ||
| let x32_lib = ($lib_dir | path join "minhook.x32.lib") | ||
| let standard_lib = ($lib_dir | path join "minhook.lib") | ||
|
|
||
| if ($x64_lib | path exists) and not ($standard_lib | path exists) { | ||
| cp $x64_lib $standard_lib | ||
| } else if ($x32_lib | path exists) and not ($standard_lib | path exists) { | ||
| cp $x32_lib $standard_lib | ||
| } |
There was a problem hiding this comment.
This is duplicating the import libraries, and the CMake config files still refer the old names. Can't we just patch the CMake in https://github.com/TsudaKageyu/minhook/blob/master/CMakeLists.txt#L73-L90 to avoid producing the postfix in the first place?
This comment is strange, as this is a Windos-specific recipe. If you use AI/LLM as part of preparing your PRs, please review them and remove unnecessary content before requesting a review, thanks! |
| let cmake_args = [ | ||
| "-GNinja" | ||
| "-DCMAKE_BUILD_TYPE=Release" | ||
| "-DBUILD_SHARED_LIBS=OFF" | ||
| $"-DCMAKE_INSTALL_PREFIX=($install_prefix)" | ||
| ] |
There was a problem hiding this comment.
Please pass along the CMAKE_ARGS environment variable to the build script, and use BUILD_SHARED_LIBS set to ON .
#29311
This commit introduces individual conda recipes for Mumble's core dependencies:
Each package includes:
These recipes replace the previous monolithic Mumble build approach
and enable better dependency management and individual package updates.
Built and tested on Linux, Windows, and macOS platforms.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).When in trouble, please check our knowledge base documentation before pinging a team.