Honda - Nidec Hybrid brake control #2671
Conversation
This reverts commit 5e7e0cf.
Merge master
jyoung8607
left a comment
There was a problem hiding this comment.
I would suggest splitting this PR into a general / Bosch support PR with a separate Nidec PR to follow up later. It's really going to help us focus review and testing.
opendbc/car/honda/values.py
Outdated
| HAS_EPB = 512 | ||
| HAS_HYBRID = 4092 | ||
| ALLOW_MANUAL_TRANS = 1024 | ||
| ALLOW_HYBRID = 8192 |
There was a problem hiding this comment.
You can do away with this.
If you're following the ALLOW_MANUAL_TRANS example, that's just me being extremely conservative about shipping #2457, to flush out any auto-detection failures since failing to the manual trans case would otherwise be non-obvious and take awhile to notice. It can go away once 0.10 has been in release for awhile.
This PR being net-new support, we don't need the extra conservative gating.
|
Sure will split tonight.
Regarding gating: Not sure there are any hybrids that do not follow these
rules, the remaining hybrids (eg: insight) have nonpublic testroute logs so
I was conservative and kept those gated out.
Edit: will do without gating and put in my spacelab build after a driver test. Presume any regressions would be found there given large user base driving on its tuned long control.
|
|
Moving to draft - new brakehold autodetect has a bug |
|
Fixed, and also added in a change to fix brakehold. |
|
Support for Honda separate brake control messages used by Nidec hybrids