Honda: fix radarless braking #2050
Conversation
|
What does this fix exactly? |
User in honda discord has logs showing that braking is maxing out at -0.5m/s2, ignoring requests up to -3.5m/s2. Not sure this works, but the goal is to imitate a new brake channel that Honda stock ACC sends while braking on hybrids to see if it fixes it. Testdrive should be imminent. The fix is similar to one I had do to for the MDX Hybrid PR. (I set as draft PR because I like the CI code review stuff) |
There was a problem hiding this comment.
Pull Request Overview
This draft PR aims to fix the braking behavior for the Honda Civic Hybrid by enabling the system to process braking requests up to -3.5 m/s². Key changes include updates to the vehicle documentation in values.py, adjustments to transmission type detection in interface.py and carstate.py, modifications to CAN message creation in hondacan.py, and expanded fingerprints and test routes to accommodate the new hybrid models.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| opendbc/car/honda/values.py | Added hybrid Civic documentation entries and a temporary test hack. |
| opendbc/car/honda/interface.py | Updated transmission type logic for Civic models with hybrid signals. |
| opendbc/car/honda/carstate.py | Introduced HYBRID_CONTROL message handling for Civic 2022. |
| opendbc/car/honda/hondacan.py | Added hybrid initialization and CAN command for hybrid control. |
| opendbc/car/tests/routes.py | Added a new test route for the 2025 Civic Hatch Hybrid model. |
| opendbc/car/honda/fingerprints.py | Included additional fingerprint entries for enhanced model support. |
Files not reviewed (2)
- opendbc/dbc/generator/honda/honda_civic_ex_2022_can.dbc: Language not supported
- opendbc/safety/safety/safety_honda.h: Language not supported
opendbc/car/honda/interface.py
Outdated
| # Civic Type R is missing 0x191 and 0x1A3 | ||
| elif candidate == CAR.HONDA_CIVIC_2022 and all(msg not in fingerprint[CAN.pt] for msg in (0x191, 0x1A3)): | ||
| ret.transmissionType = TransmissionType.manual | ||
| # New Civics dont have 0x191, but do have 0x1A3 |
There was a problem hiding this comment.
Consider correcting 'dont' to 'don't' for proper spelling.
| # New Civics dont have 0x191, but do have 0x1A3 | |
| # New Civics don't have 0x191, but do have 0x1A3 |
2a488e1 to
eb6cd7e
Compare
06e010f to
859e2be
Compare
|
Tests were successful. This is ready for review. |
2025/2026 Civic Hybrid and 2025 Acura ADX do not brake at full requested strength.
Initial fix attempts focused on radarless camera. However, recently found that the idlestop message is on all the time while stock ACC does braking. Replicating this (setting bit whenever braking) fixed braking strength on ADX and Civic Hybrid.
Todo: