这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@royjr
Copy link
Contributor

@royjr royjr commented Mar 7, 2025

This pull request addresses #1899 by refactoring the CarController update functions for HKG vehicles, separating the logic for CAN and CANFD communication protocols. The primary changes include:

  • Separated update functions for CAN and CANFD to handle their respective messaging protocols.
  • Introduced compute_common_controls to manage shared logic between CAN and CANFD, reducing redundancy.
  • Moved process_hud_alert inside the class, as it was not used externally.
  • Refactored code structure and ordering for better readability and maintainability.

@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Mar 7, 2025
@royjr royjr marked this pull request as draft March 7, 2025 00:53
@royjr royjr marked this pull request as ready for review March 7, 2025 01:23
@sshane
Copy link
Contributor

sshane commented Mar 12, 2025

this seems a bit cleaner: #1990

feel free to keep going if you see anything else

@sshane sshane closed this Mar 12, 2025
@royjr royjr deleted the hkg-split-carcontroller branch March 13, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car related to opendbc/car/ hyundai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants