How does this pass? You should need to flip all of the definitions for all the safety modes from false to true, and vice versa

We want the checksum and counter checks to fail by default, i.e. if check_checksum isn't set to false, but there's no checksum function added

I suggest renaming check_checksum to ignore_checksum and maybe a new flag for ignoring counter if needed

See: #1840 (but fix the segfault and validity setting gracefully)

We want the checksum and counter checks to fail by default, i.e. if check_checksum isn't set to false, but there's no checksum function added

This helped and I went with using ignore_checksum though I see that we get 6 fail tests from this change. (this may be expected since it's doing the check_sum yet no checksum function is set correct?)

FAILED test_hyundai.py::TestHyundaiSafetyFCEV::test_allow_engage_with_gas_pressed - AssertionError: False is not true
FAILED test_hyundai.py::TestHyundaiSafetyFCEV::test_alternative_experience_no_disengage_on_gas - AssertionError: False is not true
FAILED test_hyundai.py::TestHyundaiSafetyFCEV::test_prev_gas - AssertionError: True != False
FAILED test_hyundai.py::TestHyundaiLegacySafetyHEV::test_alternative_experience_no_disengage_on_gas - AssertionError: False is not true
FAILED test_hyundai.py::TestHyundaiLegacySafetyHEV::test_prev_gas - AssertionError: True != False
FAILED test_hyundai.py::TestHyundaiLegacySafetyHEV::test_allow_engage_with_gas_pressed - AssertionError: False is not true

I'll look into it more in-depth tomorrow but I wouldn't expect that the 6 hyundai tests to fail.

applied ignore_checksum on the following messages

This makes sense since the whole idea of defaulting that it's true is to ensure which tests are missing checksum functions or not, the 6 hyundai tests weren't using it and thus forced me to apply the ignore_checksum on both .msg. Moving onto counter now.

I didn't run into the case involving the segfault and wasn't able to reproduce it. I also didn't run into any issues with setting the skip_counter as I did with checksum. Moving to review although I expect there are some things that I'm just completely missing.

Yep, we just want to make it more obvious whenever you're skipping a counter or checksum check

This still doesn't do what we want. Rivian is untouched, but we aren't checking its checksum or counter

Merging in #1939