HKG: Revert wheel speed safety changes #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy (commaai#1845)" This reverts commit a289e79.
…)" This reverts commit 402b413.
eli-davis
pushed a commit
to eli-davis/opendbc_reference
that referenced
this pull request
Jul 15, 2025
* Revert "Hyundai CAN-FD Safety: Update vehicle speed conversion accuracy (commaai#1845)" This reverts commit 9ce5475. * Revert "Hyundai CAN-FD: Update wheel speed signal parsing (commaai#1844)" This reverts commit d708f43.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunnyhaibin, not quite sure what happened here, as I'm 95% sure we ran the openpilot tests on this stuff locally before merge, but they're currently producing a standstill mismatch between openpilot and panda. Check it out when you get a chance, and open new PRs when it's sorted out.