这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@johnewing1
Copy link
Contributor

Add support for being able to specify the scheme ( e.g. https ) in opentsdb urls


Description

Fixes #2087

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • [x ] New unit test
  • [x ] Manual test to verify querying over https

Checklist:

  • This contribution follows the project's code of conduct
  • This contribution follows the project's contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

muffix
muffix previously approved these changes Jul 6, 2020
@neilfordyce
Copy link
Contributor

Looks great. Probably worthy of updates to docs and reference configs in a couple of places:

  1. /docs/configuration.md
  2. /cmd/bosun/bosun.example.toml
  3. /docker/data/bosun.toml

@johnewing1
Copy link
Contributor Author

Looks great. Probably worthy of updates to docs and reference configs in a couple of places:

  1. /docs/configuration.md
  2. /cmd/bosun/bosun.example.toml
  3. /docker/data/bosun.toml

File 1 is for the legacy 0.5 config, so we should leave that as is.
I've updated the other two.

@johnewing1 johnewing1 merged commit 6e4dc34 into bosun-monitor:master Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bosun can't connect to opentsdb over HTTPS

3 participants