这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Feb 2, 2025

This reverts commit 15ed8d0.

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17888

📔 Objective

In 15ed8d0 we converted Renovate configuration to JSON5 to enable commenting. However, Renovate docs indicate that only the .json extension is assumed for the default configuration. The fact that default.json5 would have to be specified on all extending configurations (i.e. all our repos) meant that the Renovate scheduled run failed.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@withinfocus
Copy link
Contributor

Heh, crazy that this simple change became an issue ...

@trmartin4 trmartin4 merged commit 66032ea into main Feb 3, 2025
2 checks passed
@trmartin4 trmartin4 deleted the revert-json5 branch February 3, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants