这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 30, 2025

📔 Objective

Use JSON5 files for Renovate config, so that we can add comments to the configuration. Comments will be added in subsequent PRs. JSON5 is a superset of JSON, so existing files should not be affected, and Renovate supports it natively.

📓 Note that VSCode doesn't support JSON5 syntax highlighting out of the box, so an extension like JSON5 Kit will need to be used.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Renamed to use JSON5 for config Use JSON5 for config Jan 30, 2025
@trmartin4 trmartin4 marked this pull request as ready for review January 30, 2025 15:01
@trmartin4 trmartin4 requested a review from a team as a code owner January 30, 2025 15:01
@trmartin4 trmartin4 requested a review from withinfocus January 30, 2025 15:01
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine? Let's see what happens!

Copy link
Contributor

@mimartin12 mimartin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@trmartin4 trmartin4 merged commit 15ed8d0 into main Feb 2, 2025
2 checks passed
@trmartin4 trmartin4 deleted the use-json5 branch February 2, 2025 17:40
trmartin4 added a commit that referenced this pull request Feb 2, 2025
trmartin4 added a commit that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants