Adding comments to config now that we have JSON5 #21
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmartin4
commented
Feb 2, 2025
| ":combinePatchMinorReleases", // Do not separate patch and minor upgrades into separate PRs for the same dependency | ||
| ":dependencyDashboard", // Enable the dependency dashboard | ||
| ":separateMajorReleases", // Major releases will never be combined with minor/patch, so we can hold off on major and get incremental minors | ||
| "config:base", |
Member
Author
There was a problem hiding this comment.
@Hinton I can't find any documentation of config:base as an option. Do you have a link to what that does for us?
Member
There was a problem hiding this comment.
They renamed it to recommended apparently.
Hinton
reviewed
Feb 3, 2025
Member
Hinton
left a comment
There was a problem hiding this comment.
Many of these comments seems to be about the same as the actual code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes