这是indexloc提供的服务，不要输入任何密码
Skip to content

Adding comments to config now that we have JSON5 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Draft

Adding comments to config now that we have JSON5 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions default.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
":pinAllExceptPeerDependencies",
"github>bitwarden/renovate-config:non-pinned"
":pinAllExceptPeerDependencies", // The default is to pin all dependencies, for our non-library apps
"github>bitwarden/renovate-config:non-pinned" // We want to pull in all the configuration from our non-pinned base
]
}
9 changes: 5 additions & 4 deletions non-pinned.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
":combinePatchMinorReleases",
":dependencyDashboard",
":separateMajorReleases",
":combinePatchMinorReleases", // Do not separate patch and minor upgrades into separate PRs for the same dependency
":dependencyDashboard", // Enable the dependency dashboard
":separateMajorReleases", // Major releases will never be combined with minor/patch, so we can hold off on major and get incremental minors
"config:base",
Copy link
Member Author

@trmartin4 trmartin4 Feb 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hinton I can't find any documentation of config:base as an option. Do you have a link to what that does for us?

Copy link
Member

@Hinton Hinton Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They renamed it to recommended apparently.

"group:monorepos",
"group:monorepos", // Use all pre-configured groupings of dependencies
"github>bitwarden/renovate-config:pin-actions"
],
"commitMessagePrefix": "[deps]:",
Expand All @@ -19,6 +19,7 @@
"every 2nd week starting on the 2 week of the year before 4am on Monday"
]
},
// All of our dependencies use 2-week schedule for generating update PRs
"schedule": [
"every 2nd week starting on the 2 week of the year before 4am on Monday"
],
Expand Down
1 change: 1 addition & 0 deletions pin-actions.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
// We have identified some Github Actions that we want to pin to specific versions
"packageRules": [
{
"matchDatasources": ["github-tags"],
Expand Down