Fix podspec location for Flutter plugin system #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Flutter MIDI-CI tool in tools/flutter-ci-tool/ - Integrate Flutter builds into CMake using custom commands - Link with existing midicci-tooling library (CIToolRepository, CIDeviceModel, CIDeviceManager) - Add C++ wrapper for platform channel integration - Implement 4-screen tabbed interface (Initiator, Responder, Log, Settings) - Use Provider pattern for reactive state management - Support cross-platform builds (Linux, macOS, Windows, Android, iOS) - Optional build based on Flutter detection in CMake Link to Devin run: https://app.devin.ai/sessions/98cd60952f66496aaec0341c23ec0288 Requested by: Atsushi Eno (atsushieno@gmail.com) Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
… conflicts with struct names - Changed typedef struct CIToolRepositoryHandle* CIToolRepositoryHandle to CIToolRepository - Changed typedef struct CIDeviceManagerHandle* CIDeviceManagerHandle to CIDeviceManager - Changed typedef struct CIDeviceModelHandle* CIDeviceModelHandle to CIDeviceModel - Changed typedef struct MidiDeviceManagerHandle* MidiDeviceManagerHandle to MidiDeviceManager - Updated all function signatures in both header and implementation files to use new typedef names - Resolves clang compilation error: typedef redefinition with different types Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
… conflicts with struct names - Changed typedef struct CIToolRepositoryHandle* CIToolRepositoryHandle to CIToolRepository - Changed typedef struct CIDeviceManagerHandle* CIDeviceManagerHandle to CIDeviceManager - Changed typedef struct CIDeviceModelHandle* CIDeviceModelHandle to CIDeviceModel - Changed typedef struct MidiDeviceManagerHandle* MidiDeviceManagerHandle to MidiDeviceManager - Updated all function signatures in both header and implementation files to use new typedef names - Resolves clang compilation error: typedef redefinition with different types Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
…ompilation-errors-v2 Fix typedef compilation errors in Flutter CI tool wrapper
…ompliance - Rename directory from flutter-ci-tool to flutter_ci_tool to follow Dart package naming conventions - Update CMake references in tools/CMakeLists.txt and flutter_ci_tool/CMakeLists.txt - Maintain existing CMake build system integration - Desktop platform support already added via flutter create command Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
…ackage-name Fix Flutter package naming issue and add desktop support
- Creates standard Flutter macOS Podfile in tools/flutter_ci_tool/macos/ - Configures CocoaPods for native dependencies (ffi, path_provider) - Sets minimum macOS deployment target to 10.14 - Includes standard Flutter plugin integration setup Fixes: Exception: Podfile missing when running flutter run on macOS Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
…odfile Fix missing Podfile for Flutter macOS deployment
- Move podspec from macos/ to plugin root directory - Update source_files paths to work from plugin root - Flutter's symlink system expects podspec in plugin root, not platform subdirectory - This should resolve the CocoaPods error about missing podspec file Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
…er pub get Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Owner
|
The PR should be against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix podspec location for Flutter plugin system
Problem
PR #76 was merged but placed the podspec file in the wrong location (
tools/flutter_ci_tool/macos/midicci_flutter_gui.podspec). The original CocoaPods error still occurs:Flutter's symlink system expects the podspec to be in the plugin root directory, not in the platform subdirectory.
Solution
tools/flutter_ci_tool/macos/midicci_flutter_gui.podspectotools/flutter_ci_tool/midicci_flutter_gui.podspec(plugin root)'Classes/**/*', '../native/*.{h,cpp}'to'macos/Classes/**/*', 'native/*.{h,cpp}'to work from plugin rootflutter_uibranch for proper plugin functionalityKey Changes
tools/flutter_ci_tool/midicci_flutter_gui.podspec- Moved podspec to plugin root directory (correct location for Flutter plugins)spec.source_filespaths to referencemacos/Classes/**/*andnative/*.{h,cpp}from plugin rootflutter_uibranchflutter pub getFlutter Plugin Structure
The fix follows standard Flutter plugin conventions:
Flutter/ephemeral/.symlinks/plugins/{plugin_name}/macosto the plugin rootTesting
flutter run -d macoson Linux system (macOS not available as target device)✅ Flutter dependencies:
flutter pub getcompleted successfully, confirming valid Flutter project structure✅ Complete project structure: Merged flutter_ui branch with full Flutter plugin implementation
✅ Git changes: Podspec successfully moved to correct location and paths updated
To test the fix: Run
cd tools/flutter_ci_tool && flutter run -d macoson a macOS system to verify the CocoaPods error is resolved.Expected Result
The specific CocoaPods error should no longer appear:
Link to Devin run
https://app.devin.ai/sessions/f1b50c92410a48cf9e67c3b3ba360f81
Requested by: Atsushi Eno (atsushieno@gmail.com)