Fix Flutter package naming issue and add desktop support #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompliance - Rename directory from flutter-ci-tool to flutter_ci_tool to follow Dart package naming conventions - Update CMake references in tools/CMakeLists.txt and flutter_ci_tool/CMakeLists.txt - Maintain existing CMake build system integration - Desktop platform support already added via flutter create command Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Flutter Package Naming Issue and Add Desktop Support
Summary
This PR resolves the Dart package naming issue where "flutter-ci-tool" violated Dart naming conventions and adds desktop platform support to the Flutter project.
Changes Made
tools/flutter-ci-tooltotools/flutter_ci_toolto follow Dart naming conventions (lowercase letters and underscores only)tools/CMakeLists.txtandtools/flutter_ci_tool/CMakeLists.txtto use the new directory nameflutter create --platforms=windows,macos,linux .which generated:linux/directory)macos/directory)windows/directory)Technical Details
pubspec.yamlalready used the valid package name "midicci_flutter_gui"add_subdirectory()referencesVerification
flutter create --platforms=windows,macos,linux .runs successfully without package naming errorsflutter pub getworks correctly in the renamed directoryflutter analyzeruns successfully (with only pre-existing style warnings)Link to Devin run
https://app.devin.ai/sessions/76907e9b746d48e48c164fdb5a623f26
Requested by: Atsushi Eno (atsushieno@gmail.com)