这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@vergenzt
Copy link
Contributor

Closes #596.

@vergenzt
Copy link
Contributor Author

@amsul, any thoughts on this?

@wayou
Copy link

wayou commented Dec 23, 2014

+1 for this. sometimes we'd like to stay when selected and this even prevent the wrong click action.
pls merge :)

@amsul
Copy link
Owner

amsul commented Jan 8, 2015

Sweet! I'll merge this in for v3.5.5

Thanks :)

@amsul amsul added this to the 3.5.5 milestone Jan 8, 2015
@amsul
Copy link
Owner

amsul commented Jan 15, 2015

Hey @vergenzt, can you please bring this upstream to the latest master? I'd like to merge this in asap.

The demos and docs have been moved to gh-pages as a jekyll site and just the library code lives in master now.

Thanks!

@vergenzt
Copy link
Contributor Author

Will do!

@vergenzt
Copy link
Contributor Author

@amsul I assume I should submit a separate pull request for the gh-pages branch?

@vergenzt
Copy link
Contributor Author

Also oops. Forgot to run the build before pushing!

@vergenzt
Copy link
Contributor Author

@amsul When I run grunt build --verbose I get a warning that "Warning: Task "document-once" not found. Use --force to continue." Any ideas? :/

@amsul
Copy link
Owner

amsul commented Jan 21, 2015

@vergenzt ah, that task was removed. I just commit the fix to the Gruntfile. Can you please try that again?

And yes, the docs changes should go in the gh-pages branch now :)

@vergenzt
Copy link
Contributor Author

Sorry this is taking so long, I'm just getting confused about what's expected. -_-

Should I commit and add the compiled and minified results of grunt build --verbose to the PR? It changes some translations in addition to the themes and js files.

@vergenzt
Copy link
Contributor Author

Ping?

@amsul
Copy link
Owner

amsul commented Jan 28, 2015

As long as grunt test passes, you should be good here :)

I'll merge this in over the weekend. Thanks!!

@amsul
Copy link
Owner

amsul commented Jan 28, 2015

Looking at the changed files now.. can you please also add tests for these two cases?

Right after this test would be perfect: Base keyboard events - Set and clear

@vergenzt
Copy link
Contributor Author

vergenzt commented Feb 6, 2015

Yes! I'm sorry, I thought I had done that.

Really sorry about the latency on this. I started classes a few weeks ago and have been swamped.

@amsul
Copy link
Owner

amsul commented Feb 9, 2015

I wasn't able to merge the commit automatically so I did a manual merge.

Thanks for the contribution!

@amsul amsul closed this Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add boolean closeOnSelect option

3 participants