-
Notifications
You must be signed in to change notification settings - Fork 1k
Add boolean closeOnSelect and closeOnClear options
#600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@amsul, any thoughts on this? |
|
+1 for this. sometimes we'd like to stay when selected and this even prevent the wrong click action. |
|
Sweet! I'll merge this in for v3.5.5 Thanks :) |
|
Hey @vergenzt, can you please bring this upstream to the latest The demos and docs have been moved to Thanks! |
|
Will do! |
626fbae to
2f6c315
Compare
|
@amsul I assume I should submit a separate pull request for the |
|
Also oops. Forgot to run the build before pushing! |
|
@amsul When I run |
|
@vergenzt ah, that task was removed. I just commit the fix to the Gruntfile. Can you please try that again? And yes, the docs changes should go in the |
2f6c315 to
6b8e07f
Compare
|
Sorry this is taking so long, I'm just getting confused about what's expected. -_- Should I commit and add the compiled and minified results of |
|
Ping? |
|
As long as I'll merge this in over the weekend. Thanks!! |
|
Looking at the changed files now.. can you please also add tests for these two cases? Right after this test would be perfect: |
|
Yes! I'm sorry, I thought I had done that. Really sorry about the latency on this. I started classes a few weeks ago and have been swamped. |
|
I wasn't able to merge the commit automatically so I did a manual merge. Thanks for the contribution! |
Closes #596.