这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Kurami32
Copy link
Collaborator

Description
This should fix #1568 - Now you can create folders in the same moveCopy prompt and the list in there gets updated (see the video).

Also added reload in some places and removed the auto-navigation when creating a new file and folder - I left it commented for now because I don't know if you want to keep it (In that case is more easy to revert), but personally I found it a bit annoying.

According to the contributing guide, A PR should contain:

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details
This is how it looks when creating a folder now:

2025-11-13.15-40-31.mp4

(btw, I know that we have a prompt for newDir but I had issues like syncing or the creation of the folders itself)

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 13, 2025

I think some can fail due to the removal of goToItem.

Yep, was for that.

@Kurami32 Kurami32 changed the title Update moveCopy and remove auto-navigation Fix moveCopy new folder creation Nov 13, 2025
@gtsteffaniak
Copy link
Owner

looks slick! I really like how you put the input field inline replacing the button. This looks great!

@gtsteffaniak
Copy link
Owner

was the intention for removing goToItem so it doesn't move the user to the folder after creation? I can help update the tests to expect that if you want to remove that functionality

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 13, 2025

was the intention for removing goToItem so it doesn't move the user to the folder after creation? I can help update the tests to expect that if you want to remove that functionality

Yup, in new folder and file creation. And I would appreciate your help, I'm not familiar with the tests yet.

I'll do a commit removing it again.

@Kurami32
Copy link
Collaborator Author

Thanks! And now is better with the button in notifications :)

Btw, don't merge the PR yet, I'll a validation for check if folders with the same name exist.

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 14, 2025

I've changed the close hovers in ReplaceRename.vue so that way if a conflict happen when copying or moving you're still in the copyMove prompt clicking "cancel", but doesn't look great after that:

image

The fix for this is remove the loading spinner (which also hide the buttons), but I want to ask first if you're ok with removing it 😅


Another bug is that if you click "replace" in the ReplaceRename prompt, the item becomes corrupted with 0.0b of size.

image

I don't think that the code here can be causing that, so maybe is a backend issue (?)

@gtsteffaniak
Copy link
Owner

I can't replicate the corrupted issue when I try to replace works as expected. does this happen all the time?

@Kurami32
Copy link
Collaborator Author

Kurami32 commented Nov 14, 2025

Yep, every time. Not just here, in stable too.

2025-11-14.10-20-57.mp4

@gtsteffaniak
Copy link
Owner

oh replacing its own file with itself?

Yeah replacing with itself should be possible, let me check on that.

@gtsteffaniak
Copy link
Owner

should be good to go from my perspective!

@Kurami32
Copy link
Collaborator Author

Yup! To me too, you can merge it.

Btw, I want to ask something... Why you always remove the border-radius from plyr, is intentional? I just want to know 😅
Because that makes the audio player square.

@gtsteffaniak
Copy link
Owner

because you can see the border radius on videos doesn't go to the edges. you see the radius clip the video corners a little bit.

@gtsteffaniak gtsteffaniak merged commit 7f262b2 into dev/v1.1.0 Nov 15, 2025
17 checks passed
@Kurami32 Kurami32 deleted the fix-moveCopy branch November 15, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants