-
Notifications
You must be signed in to change notification settings - Fork 194
Fix moveCopy new folder creation #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think some can fail due to the removal of goToItem. Yep, was for that. |
|
looks slick! I really like how you put the input field inline replacing the button. This looks great! |
|
was the intention for removing goToItem so it doesn't move the user to the folder after creation? I can help update the tests to expect that if you want to remove that functionality |
Yup, in new folder and file creation. And I would appreciate your help, I'm not familiar with the tests yet. I'll do a commit removing it again. |
|
Thanks! And now is better with the button in notifications :) Btw, don't merge the PR yet, I'll a validation for check if folders with the same name exist. |
|
I can't replicate the corrupted issue when I try to replace works as expected. does this happen all the time? |
|
Yep, every time. Not just here, in 2025-11-14.10-20-57.mp4 |
|
oh replacing its own file with itself? Yeah replacing with itself should be possible, let me check on that. |
|
should be good to go from my perspective! |
|
Yup! To me too, you can merge it. Btw, I want to ask something... Why you always remove the border-radius from plyr, is intentional? I just want to know 😅 |
|
because you can see the border radius on videos doesn't go to the edges. you see the radius clip the video corners a little bit. |
Description
This should fix #1568 - Now you can create folders in the same moveCopy prompt and the list in there gets updated (see the video).
Also added reload in some places and removed the auto-navigation when creating a new file and folder - I left it commented for now because I don't know if you want to keep it (In that case is more easy to revert), but personally I found it a bit annoying.
According to the contributing guide, A PR should contain:
Additional Details
This is how it looks when creating a folder now:
2025-11-13.15-40-31.mp4
(btw, I know that we have a prompt for newDir but I had issues like syncing or the creation of the folders itself)