Add API surface for feature levels #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a dictionary member that can be used for feature level requests in the future. It currently does not accept any value; the only thing it does is make sure that _if_ a feature level is requested, it can be rejected. This is the appropriate behavior for a browser to have before it adds support for any other feature levels. It has type `any` so that it `requestAdapter()` can return `null` (rather than rejecting) regardless of how we end up phrasing feature levels in the future. This is planned to be used for Compat mode, likely simply by accepting a string value of `"compat"`. Issue: 4656
Contributor
|
Previews, as seen when this build job started (e7f7a0e): |
Contributor
|
I might be overthinking this, but using the word "feature" for |
Contributor
Author
|
You're right, I even made that comment myself on the last PR and totally forgot about it. |
This reverts commit e706930.
Contributor
Author
|
Reverted to |
Contributor
Author
|
Oh, I should update the compat proposal doc too. |
mwyrzykowski
approved these changes
Sep 11, 2024
Contributor
Author
|
Actually I'm going to update the compat proposal separately because the change is nontrivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a dictionary member that can be used for feature level requests in the future. It currently does not accept any value; the only thing it does is make sure that if anything is passed to
featureLevel, we know not to ignore it. This is the appropriate behavior for a browser to have before it adds support for any other feature levels.Proposing this for M0 to set up the API surface.
It has type
anyso that itrequestAdapter()can returnnull(rather than rejecting) regardless of what types we end up using to describe feature levels in the future. This is to make it consistent with the future case where the browser does understand the feature level but the hardware doesn't support it (which probably should returnnull- the request was OK but there was no adapter to return).This is planned to be used for Compat mode, likely simply by accepting a string value, e.g.
"compat"(% bikeshedding).Issue: #4656