这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@kainino0x
Copy link
Contributor

Rendered

Designed/written in collaboration with @kenrussell.

@Kangz
Copy link
Contributor

Kangz commented Apr 11, 2019

Thanks for putting this together, the proposal looks good. Have we also investigated the tradeoffs for an unbuffered alternative?

@kainino0x
Copy link
Contributor Author

We didn't consider it. I don't think it makes much of a difference - either way, the operation occurs atomically at the unbuffered operation (be it texture.copyFromImageBitmap or queue.submit), and would have the same semantics (I think).

@kdashg
Copy link
Contributor

kdashg commented Apr 15, 2019

It would be nice to try to expand this to actual 3d sliced uploads later, but let's get this in first.

Copy link
Contributor

@kdashg kdashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to approve with the changes requests Kai transcribed on my behalf. (or convince me otherwise!)

@kainino0x kainino0x self-assigned this May 1, 2019
@kainino0x kainino0x force-pushed the imagebitmap branch 2 times, most recently from e9b1c9d to 8d5bea8 Compare May 7, 2019 19:16
@kainino0x
Copy link
Contributor Author

Done and rebased.

@Kangz
Copy link
Contributor

Kangz commented Jun 3, 2019

I think this is ready to be landed, the group agreed to this PR a while ago.

Copy link
Contributor

@kdashg kdashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kainino0x
Copy link
Contributor Author

kainino0x commented Jun 4, 2019

From the 2019-04-15 minutes tl;dr:

ImageBitmap #266

  • Concern that the ImageBitmap needs to be remembered between encode and submission. Discussion around read-only and weak handles.
  • ImageBitmap has to be not detached.
  • People like the proposal (but no consensus recorded)

@kainino0x
Copy link
Contributor Author

The alternative is for this copy to be outside of a command buffer (queue/device timeline). I think this is somewhat hard to spec without multiqueue spec.

There was some contingent, IIRC, who wanted to have versions of some copies outside of buffers. We should/will revisit moving this out if we do that.

@kainino0x kainino0x merged commit 1ceaa23 into gpuweb:master Jun 4, 2019
@kainino0x kainino0x deleted the imagebitmap branch June 4, 2019 01:08
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
Unsurprisingly, a lot of WPT-related tooling breaks when there's a
unicode character here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants