-
Notifications
You must be signed in to change notification settings - Fork 345
Proposal for copyImageBitmapToTexture #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for putting this together, the proposal looks good. Have we also investigated the tradeoffs for an unbuffered alternative? |
|
We didn't consider it. I don't think it makes much of a difference - either way, the operation occurs atomically at the unbuffered operation (be it texture.copyFromImageBitmap or queue.submit), and would have the same semantics (I think). |
|
It would be nice to try to expand this to actual 3d sliced uploads later, but let's get this in first. |
kdashg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to approve with the changes requests Kai transcribed on my behalf. (or convince me otherwise!)
e9b1c9d to
8d5bea8
Compare
|
Done and rebased. |
|
I think this is ready to be landed, the group agreed to this PR a while ago. |
kdashg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
From the 2019-04-15 minutes tl;dr:
|
|
The alternative is for this copy to be outside of a command buffer (queue/device timeline). I think this is somewhat hard to spec without multiqueue spec. There was some contingent, IIRC, who wanted to have versions of some copies outside of buffers. We should/will revisit moving this out if we do that. |
Unsurprisingly, a lot of WPT-related tooling breaks when there's a unicode character here.
Rendered
Designed/written in collaboration with @kenrussell.