Fixed overflow when width of buffer exceeds screen width | This doesn… #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t work for windows. | gosuri#3 This gets the terminal size and validates if buffer width exceeds screen width.
Owner
There was a problem hiding this comment.
I'd like to avoid bringing in a dependency of this size. Will be great if you could please copy the relevent code and place it under vendor directory (including the licence)
Owner
|
Thank you. Please check my comments. Also, please rebase your code and add a test to writer_test.go |
Author
|
@polyrabbit You can try out this, inspired by uilive. |
|
Many thanks @apoorvam , I'll give it a try! |
Merged
Closed
Collaborator
|
Fixed with #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed overflow when width of buffer exceeds screen width. This doesnt work for windows.
This gets the terminal size and validates if buffer width exceeds screen width.