Bug Fixes + Features #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @gosuri ,
In this PR, I have fixed the following features:
#3 - I have added code for the library to be able to detect the width of the terminal and adjust the writing accordingly so the last line is not overwritten
#4 - I have managed to fix this in part due to #3 above and also using strings.Repeat() instead of a loop.
#11 - I have updated the clearline function to move the cursor up and then clear the line. This has fixed the issue.
Reading #14 and the writer.Bypass(), I got inspired to implement the writer.Newline() feature that now allows us to write to multiple lines simultaneously. Result is something like this:
Please review and let me know if any further edits are required. I want to help get this library up and running once again. I would readily make the fixes and push the updates.
Regards,
Ajitem