这是indexloc提供的服务，不要输入任何密码
Skip to content

[flutter_tools] remove mocks, globals from golden comparator and test runner tests | Reland #81512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

[flutter_tools] remove mocks, globals from golden comparator and test runner tests | Reland #81512

merged 1 commit into from
Apr 30, 2021

Conversation

jonahwilliams
Copy link
Contributor

Reverts #81487

Revert "Revert "[flutter_tools] remove mocks, globals from golden com…
2e4a56a 
…parator and test runner tests (#81423)" (#81487)"

This reverts commit 027d4ec.
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 29, 2021
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@jonahwilliams
Copy link
Contributor Author

The cause of the failures was unrelated

@jonahwilliams jonahwilliams changed the title Revert "Revert "[flutter_tools] remove mocks, globals from golden comparator and test runner tests"" [flutter_tools] remove mocks, globals from golden comparator and test runner tests | Reland Apr 29, 2021
goderbauer
goderbauer approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit e362570 into master Apr 30, 2021
@jonahwilliams jonahwilliams deleted the revert-81487-revert-81423-oh_jeeze_even_more_mocks branch April 30, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahwilliams @goderbauer