这是indexloc提供的服务,不要输入任何密码
Skip to content

Revert "[flutter_tools] remove mocks, globals from golden comparator and test runner tests" #81487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

goderbauer
Copy link
Member

Reverts #81423

test\integration.shard\overall_experience_test.dart: flutter error messages include a DevTools link started failing on windows with this commit. Reverting to see if it fixes things.

https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_4_5/21/overview

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 29, 2021
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@goderbauer
Copy link
Member Author

/cc @jonahwilliams @dnfield

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member Author

Submitting on red to attempt to fix the tree. Submitting without waiting for checks since it reverts last commit.

@goderbauer goderbauer merged commit 027d4ec into master Apr 29, 2021
@goderbauer goderbauer deleted the revert-81423-oh_jeeze_even_more_mocks branch April 29, 2021 17:56
jonahwilliams pushed a commit that referenced this pull request Apr 29, 2021
…parator and test runner tests (#81423)" (#81487)"

This reverts commit 027d4ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants