这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Sep 17, 2025

fix typo above function that have mentions build.gradle/.kts while the function returns settings.gradle/.kts file

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 17, 2025
@AbdeMohlbi AbdeMohlbi changed the title WIP fix typo in comments to mention settings.gradle/.kts instead of build.gradle/.kts Sep 17, 2025
@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review September 17, 2025 10:11
@reidbaker reidbaker self-requested a review September 17, 2025 14:31
@reidbaker reidbaker requested a review from a team September 17, 2025 14:31
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Sep 17, 2025
Merged via the queue into flutter:master with commit 8f94cb0 Sep 17, 2025
149 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 17, 2025
flutter/flutter@8d0b31d...8f94cb0

2025-09-17 mohellebiabdessalem@gmail.com fix typo in comments to mention `settings.gradle/.kts` instead of `build.gradle/.kts` (flutter/flutter#175486)
2025-09-17 mohellebiabdessalem@gmail.com replace ` Charset.forName("UTF-8")` with `StandardCharsets.UTF_8` to address linter issues (flutter/flutter#175275)
2025-09-17 engine-flutter-autoroll@skia.org Roll Skia from 283a8ff3bca5 to a5a8f1df14bb (6 revisions) (flutter/flutter#175512)
2025-09-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 649eef6040a1 to 116f7fe72839 (3 revisions) (flutter/flutter#175474)
2025-09-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wzk_HjPLGu-mlg5hC... to 0_jKqLGnkILvQ5C8a... (flutter/flutter#175468)
2025-09-16 34871572+gmackall@users.noreply.github.com Sync 3.35.3 and 3.35.4 notes from stable to master (flutter/flutter#175461)
2025-09-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 700de52f29a9 to 649eef6040a1 (4 revisions) (flutter/flutter#175455)
2025-09-16 mohellebiabdessalem@gmail.com Update gradle_errors.dart to use constants defined in gradle_utils.dart (flutter/flutter#174760)
2025-09-16 mohellebiabdessalem@gmail.com Update gradle_utils.dart to use `constant` instead of `final` (flutter/flutter#175443)
2025-09-16 mohellebiabdessalem@gmail.com fix typo in test documentation (flutter/flutter#174292)
2025-09-16 1961493+harryterkelsen@users.noreply.github.com [benchmarks] Allow passing --local-web-sdk and --build-mode flags to benchmarks (flutter/flutter#175199)
2025-09-16 34871572+gmackall@users.noreply.github.com Roll pub packages and update lockfiles (flutter/flutter#175446)
2025-09-16 ryjohn@google.com [docs] Add initial version of Flutter AI rules (flutter/flutter#175011)
2025-09-16 mohellebiabdessalem@gmail.com Remove  redundant `public` modifier  for interface members in MouseCursorPlugin.java (flutter/flutter#175281)
2025-09-16 mohellebiabdessalem@gmail.com Remove the unnecessary semicolon at the end of the line in `ProcessTextPlugin.java` (flutter/flutter#175280)
2025-09-16 mohellebiabdessalem@gmail.com Remove unnecessary `toString()` call in `ImageReaderPlatformViewRenderTarget.java` (flutter/flutter#175286)
2025-09-16 mohellebiabdessalem@gmail.com Refactor `AccessibilityBridge.java` to address linter issues (flutter/flutter#175277)
2025-09-16 mohellebiabdessalem@gmail.com Replace `.size() == 0` with `isEmpty()` in `PlatformPlugin.java` (flutter/flutter#175285)
2025-09-16 dkwingsmt@users.noreply.github.com Allow Passing an AnimationController to CircularProgressIndicator and LinearProgressIndicator (flutter/flutter#174605)
2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 7d160bbf9403 to 283a8ff3bca5 (11 revisions) (flutter/flutter#175436)
2025-09-16 codefu@google.com chore: move engine docs out of engine/ and into docs/ (flutter/flutter#175195)
2025-09-16 jason-simmons@users.noreply.github.com [Impeller] Disable the render target cache when creating a snapshot in DlImageImpeller::MakeFromYUVTextures (flutter/flutter#174912)
2025-09-16 mohellebiabdessalem@gmail.com Remove redundant public modifier in `PlatformViewRenderTarget.java` (flutter/flutter#175284)
2025-09-16 jessiewong401@gmail.com Update NDK to The Latest Stable (flutter/flutter#175365)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…ild.gradle/.kts` (flutter#175486)

fix typo above function that have mentions `build.gradle/.kts` while the
function returns `settings.gradle/.kts` file

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I listed at least one issue that this PR fixes in the description
above.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
…ild.gradle/.kts` (flutter#175486)

fix typo above function that have mentions `build.gradle/.kts` while the
function returns `settings.gradle/.kts` file

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I listed at least one issue that this PR fixes in the description
above.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants