-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Remove references to dart:js_util #176323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmm, the failing test ( cc @srujzs |
|
Yeah, this is a good question. The list of audited libraries have been stale even before we migrated to |
|
Thanks for catching this, @fishythefish! Yes, Feel free to add |
mdebbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Up to you @fishythefish, but it may be simple enough to update the allowlist in this PR. LGTM otherwise! |
3ee65a5 to
067d821
Compare
|
I'll go ahead and update the test's allowlist in this PR with a |
Flutter has been migrated from dart:js_util (which is unsupported by dart2wasm) to dart:js_interop, so we can remove/migrate all the remaining references to js_util.
067d821 to
f6d7610
Compare
…10170) Manual roll requested by tarrinneal@google.com flutter/flutter@65aca36...5c0c9e9 2025-10-03 engine-flutter-autoroll@skia.org Roll Packages from 5fd5f74 to e401aeb (4 revisions) (flutter/flutter#176466) 2025-10-03 engine-flutter-autoroll@skia.org Roll Dart SDK from fdd90f38d6a0 to 0009748aed50 (3 revisions) (flutter/flutter#176461) 2025-10-03 engine-flutter-autoroll@skia.org Roll Skia from f86ae4113254 to b842026480e0 (3 revisions) (flutter/flutter#176458) 2025-10-03 engine-flutter-autoroll@skia.org Roll Skia from 1720a85a507e to f86ae4113254 (1 revision) (flutter/flutter#176443) 2025-10-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Vnoygds8HtDUvGLCK... to HUhTcRn-LUXa2Salu... (flutter/flutter#176442) 2025-10-03 engine-flutter-autoroll@skia.org Roll Skia from cf339ab390c2 to 1720a85a507e (4 revisions) (flutter/flutter#176439) 2025-10-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 4f90a06328cb to fdd90f38d6a0 (7 revisions) (flutter/flutter#176431) 2025-10-02 engine-flutter-autoroll@skia.org Roll Skia from 05c1f5803415 to cf339ab390c2 (11 revisions) (flutter/flutter#176426) 2025-10-02 15619084+vashworth@users.noreply.github.com Add deeplinking for UIScene migration (flutter/flutter#176303) 2025-10-02 vegorov@google.com Upgrade packages (flutter/flutter#176411) 2025-10-02 36861262+QuncCccccc@users.noreply.github.com Update localization from translation console (flutter/flutter#176324) 2025-10-02 jessiewong401@gmail.com Update Framework CI to Use NDK r28c (flutter/flutter#176214) 2025-10-02 fishythefish@users.noreply.github.com Remove references to dart:js_util (flutter/flutter#176323) 2025-10-02 engine-flutter-autoroll@skia.org Roll Packages from 321a584 to 5fd5f74 (6 revisions) (flutter/flutter#176409) 2025-10-02 matt.kosarek@canonical.com Windowing integration tests now await change futures if a changes is expected + commenting our erroneous icon in Runner.rc for win32 (flutter/flutter#176312) 2025-10-02 katelovett@google.com Fix platform specific semantics for time picker buttons (flutter/flutter#176373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Flutter has been migrated from dart:js_util (which is unsupported by dart2wasm) to dart:js_interop, so we can remove/migrate all the remaining references to js_util.
Flutter has been migrated from dart:js_util (which is unsupported by dart2wasm) to dart:js_interop, so we can remove/migrate all the remaining references to js_util.
Flutter has been migrated from dart:js_util (which is unsupported by dart2wasm) to dart:js_interop, so we can remove/migrate all the remaining references to js_util.