这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fishythefish
Copy link
Contributor

Flutter has been migrated from dart:js_util (which is unsupported by dart2wasm) to dart:js_interop, so we can remove/migrate all the remaining references to js_util.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Sep 30, 2025
@fishythefish fishythefish marked this pull request as ready for review September 30, 2025 23:37
@fishythefish
Copy link
Contributor Author

Hmm, the failing test (js_access_test) is probably worth looking into more deeply. It looks like the intent was to prevent un-audited libraries from accessing potentially unsafe APIs in dart:js_util. However, since Flutter has been migrated off dart:js_util, that check trivially passes. The equivalent APIs are found in dart:js_interop_unsafe, and it looks like several un-audited libraries use it.

cc @srujzs

@srujzs
Copy link
Contributor

srujzs commented Oct 1, 2025

Yeah, this is a good question. The list of audited libraries have been stale even before we migrated to dart:js_interop_unsafe (probably due to the use of the package:js/js_util.dart import instead). @mdebbar, do we find this test still useful, and if so, should we update the audited list to include all usages of dart:js_interop_unsafe (which contain many of the same members with "unsafe" access potential as js_util)?

@mdebbar
Copy link
Contributor

mdebbar commented Oct 1, 2025

Thanks for catching this, @fishythefish!

Yes, js_access_test is still important and it should've been updated a while ago with dart:js_interop_unsafe.

Feel free to add skip: true for now. I'll file an issue to get it back in working order.

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srujzs
Copy link
Contributor

srujzs commented Oct 1, 2025

Up to you @fishythefish, but it may be simple enough to update the allowlist in this PR. LGTM otherwise!

@fishythefish
Copy link
Contributor Author

I'll go ahead and update the test's allowlist in this PR with a TODO(176365) to clean up those uses.

Flutter has been migrated from dart:js_util (which is unsupported by
dart2wasm) to dart:js_interop, so we can remove/migrate all the
remaining references to js_util.
@fishythefish fishythefish added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Oct 2, 2025
Merged via the queue into flutter:master with commit d938e30 Oct 2, 2025
186 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2025
@fishythefish fishythefish deleted the cleanup-js-util branch October 2, 2025 17:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 3, 2025
…10170)

Manual roll requested by tarrinneal@google.com

flutter/flutter@65aca36...5c0c9e9

2025-10-03 engine-flutter-autoroll@skia.org Roll Packages from 5fd5f74 to e401aeb (4 revisions) (flutter/flutter#176466)
2025-10-03 engine-flutter-autoroll@skia.org Roll Dart SDK from fdd90f38d6a0 to 0009748aed50 (3 revisions) (flutter/flutter#176461)
2025-10-03 engine-flutter-autoroll@skia.org Roll Skia from f86ae4113254 to b842026480e0 (3 revisions) (flutter/flutter#176458)
2025-10-03 engine-flutter-autoroll@skia.org Roll Skia from 1720a85a507e to f86ae4113254 (1 revision) (flutter/flutter#176443)
2025-10-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Vnoygds8HtDUvGLCK... to HUhTcRn-LUXa2Salu... (flutter/flutter#176442)
2025-10-03 engine-flutter-autoroll@skia.org Roll Skia from cf339ab390c2 to 1720a85a507e (4 revisions) (flutter/flutter#176439)
2025-10-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 4f90a06328cb to fdd90f38d6a0 (7 revisions) (flutter/flutter#176431)
2025-10-02 engine-flutter-autoroll@skia.org Roll Skia from 05c1f5803415 to cf339ab390c2 (11 revisions) (flutter/flutter#176426)
2025-10-02 15619084+vashworth@users.noreply.github.com Add deeplinking for UIScene migration (flutter/flutter#176303)
2025-10-02 vegorov@google.com Upgrade packages (flutter/flutter#176411)
2025-10-02 36861262+QuncCccccc@users.noreply.github.com Update localization from translation console (flutter/flutter#176324)
2025-10-02 jessiewong401@gmail.com Update Framework CI to Use NDK r28c (flutter/flutter#176214)
2025-10-02 fishythefish@users.noreply.github.com Remove references to dart:js_util (flutter/flutter#176323)
2025-10-02 engine-flutter-autoroll@skia.org Roll Packages from 321a584 to 5fd5f74 (6 revisions) (flutter/flutter#176409)
2025-10-02 matt.kosarek@canonical.com Windowing integration tests now await change futures if a changes is expected + commenting our erroneous icon in Runner.rc for win32 (flutter/flutter#176312)
2025-10-02 katelovett@google.com Fix platform specific semantics for time picker buttons (flutter/flutter#176373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Oct 7, 2025
Flutter has been migrated from dart:js_util (which is unsupported by
dart2wasm) to dart:js_interop, so we can remove/migrate all the
remaining references to js_util.
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
Flutter has been migrated from dart:js_util (which is unsupported by
dart2wasm) to dart:js_interop, so we can remove/migrate all the
remaining references to js_util.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants