Fixed some floating point inaccuracies in TextContents #162351

gaaclarke · 2025-01-28T23:46:47Z

issue: #149652

before

Animating from 0.444x to 0.445x

after

Animating from 0.444x to 0.445x

diff

Diff at 0.444x

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2025-01-28T23:48:01Z

I tried to add a TextContents unit test, but I couldn't get it working. This is instead measuring the distance between 2 letters being rendered.

gaaclarke · 2025-01-28T23:53:00Z

Look at the difference between the "b" and the "r", it's much better in the after gif.

gaaclarke · 2025-01-28T23:55:35Z

engine/src/flutter/impeller/entity/contents/text_contents.cc

+          glyph_bounds.GetLeftTop() +
+          (basis_transform * glyph_position.position);


@jonahwilliams this is this the thing you were talking about the other day where we scale and unscale when calculating this. That doesn't happen anymore.

jonahwilliams

Makes sense this would be causing rounding problems.

Can you double check if this correctly handles transformed/scaled text? See #151521 for an example

flutter-dashboard · 2025-01-29T00:51:11Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162351 at sha ae96d80

gaaclarke · 2025-01-29T16:20:22Z

Makes sense this would be causing rounding problems.

Can you double check if this correctly handles transformed/scaled text? See #151521 for an example

impeller_Play_AiksTest_CanRenderTextFrameWithInvertedTransform_Metal is giving bad golden tests. I think this is probably the same concern you had, right?

jonahwilliams · 2025-01-29T16:41:25Z

Yeah that is testing an invert on the text

gaaclarke · 2025-01-29T17:45:12Z

Yeah that is testing an invert on the text

Okay, I've addressed the RTL test. PTAL.

jonahwilliams

LGTM

auto-submit · 2025-01-30T00:19:23Z

autosubmit label was removed for flutter/flutter/162351, because Pull request flutter/flutter/162351 is not in a mergeable state.

auto-submit · 2025-01-30T16:53:05Z

autosubmit label was removed for flutter/flutter/162351, because - The status or check suite Windows windows_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ter#162049)" (flutter#162392)" This reverts some of commit d048c77, just the testing parts.

gaaclarke · 2025-01-30T17:49:32Z

This PR depended on some of the testing code that got reverted in the adjust UV PR. I've brought it over into this one.

flutter-dashboard · 2025-01-30T19:04:48Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162351 at sha aee09d9

…er/flutter#162351)

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 58529443+srujzs@users.noreply.github.com Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 jonahwilliams@google.com [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 codefu@google.com Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 bdero@google.com [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 jonahwilliams@google.com [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162542) 2025-01-31 1961493+harryterkelsen@users.noreply.github.com [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 mdebbar@google.com [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 bkonyi@google.com [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 jason-simmons@users.noreply.github.com Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 jason-simmons@users.noreply.github.com [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 15619084+vashworth@users.noreply.github.com Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 yaostyle@gmail.com Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 tessertaha@gmail.com [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 120297255+PurplePolyhedron@users.noreply.github.com fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162476) 2025-01-31 stuartmorgan@google.com Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 magder@google.com Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 30870216+gaaclarke@users.noreply.github.com Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 yjbanov@google.com Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 matanlurey@users.noreply.github.com Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 codefu@google.com Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 andrewrkolos@gmail.com Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 30870216+gaaclarke@users.noreply.github.com Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 mdebbar@google.com Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 bruno.leroux@gmail.com Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 tessertaha@gmail.com Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 jonahwilliams@google.com [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 victorsanniay@gmail.com Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 jonahwilliams@google.com [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 34871572+gmackall@users.noreply.github.com [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 137522957+ChrisCRCB@users.noreply.github.com fix slider semantic label (flutter/flutter#162304) 2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 andrewrkolos@gmail.com Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 andrewrkolos@gmail.com remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 jonahwilliams@google.com [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 43054281+camsim99@users.noreply.github.com Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 38378650+hgraceb@users.noreply.github.com Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 bkonyi@google.com Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

issue: flutter#149652 Animating from 0.444x to 0.445x ![before-pos](https://github.com/user-attachments/assets/3b561e35-68ca-49ca-aa3e-e2c224ae06c5) Animating from 0.444x to 0.445x ![after-pos](https://github.com/user-attachments/assets/3ef67ec9-29ce-481a-83ff-cb27fbe2ddca) Diff at 0.444x ![444](https://github.com/user-attachments/assets/2a309f2d-65ad-4be2-bc35-7b9df5639c0f) - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

This is a cherry-pick for all the changes that went into fixing #149652 It looks like a lot but most of it is testing and refactoring. ## PRs included - #161625 - #162351 - #162415 - #162555 - #162824 ## Impacted Users All users of Impeller. ## Impact Description Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales ## Workaround Use skia. ## Risk Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. ## Test Coverage Yes. ## Validation Steps The reproduction code in #149652 is good.

This is a cherry-pick for all the changes that went into fixing flutter#149652 It looks like a lot but most of it is testing and refactoring. - flutter#161625 - flutter#162351 - flutter#162415 - flutter#162555 - flutter#162824 All users of Impeller. Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales Use skia. Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. Yes. The reproduction code in flutter#149652 is good.

This is a cherry-pick for all the changes that went into fixing flutter/flutter#149652 It looks like a lot but most of it is testing and refactoring. ## PRs included - flutter/flutter#161625 - flutter/flutter#162351 - flutter/flutter#162415 - flutter/flutter#162555 - flutter/flutter#162824 ## Impacted Users All users of Impeller. ## Impact Description Animating text with translations and scales can cause: - jitter between glyphs - jitter between glyphs and the baseline - artifacts when rendering glyphs at non integer scales ## Workaround Use skia. ## Risk Since this edits how text is rendered, the risk is pretty high. The actual changes are small and there are unit tests for them. Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic. ## Test Coverage Yes. ## Validation Steps The reproduction code in flutter/flutter#149652 is good.

…er/flutter#162351)

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 58529443+srujzs@users.noreply.github.com Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 jonahwilliams@google.com [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 codefu@google.com Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 bdero@google.com [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 jonahwilliams@google.com [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162542) 2025-01-31 1961493+harryterkelsen@users.noreply.github.com [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 mdebbar@google.com [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 bkonyi@google.com [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 jason-simmons@users.noreply.github.com Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 jason-simmons@users.noreply.github.com [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 15619084+vashworth@users.noreply.github.com Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 yaostyle@gmail.com Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 tessertaha@gmail.com [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 120297255+PurplePolyhedron@users.noreply.github.com fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162476) 2025-01-31 stuartmorgan@google.com Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 magder@google.com Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 30870216+gaaclarke@users.noreply.github.com Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 yjbanov@google.com Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 matanlurey@users.noreply.github.com Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 codefu@google.com Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 andrewrkolos@gmail.com Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 30870216+gaaclarke@users.noreply.github.com Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 mdebbar@google.com Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 bruno.leroux@gmail.com Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 tessertaha@gmail.com Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 jonahwilliams@google.com [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 victorsanniay@gmail.com Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 jonahwilliams@google.com [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 34871572+gmackall@users.noreply.github.com [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 137522957+ChrisCRCB@users.noreply.github.com fix slider semantic label (flutter/flutter#162304) 2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 andrewrkolos@gmail.com Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 andrewrkolos@gmail.com remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 jonahwilliams@google.com [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 43054281+camsim99@users.noreply.github.com Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 38378650+hgraceb@users.noreply.github.com Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 bkonyi@google.com Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

Fixed some inaccuracies in the font math

ae96d80

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 28, 2025

gaaclarke changed the title ~~Fixed some inaccuracies in the font math~~ Fixed some floating point inaccuracies in TextContents Jan 28, 2025

gaaclarke requested a review from jonahwilliams January 28, 2025 23:47

gaaclarke commented Jan 28, 2025

View reviewed changes

jonahwilliams reviewed Jan 29, 2025

View reviewed changes

flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 29, 2025

mrcendre mentioned this pull request Jan 29, 2025

[Impeller] Jittery glyphs when animating text transformation #149652

Closed

fixed RTL text

8105261

gaaclarke requested a review from jonahwilliams January 29, 2025 17:45

jonahwilliams approved these changes Jan 29, 2025

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

gaaclarke and others added 2 commits January 30, 2025 08:31

Merge branch 'master' into text-pos-tweak

97f1701

fixed bad merge

01b711e

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

Revert "Reverts "Started adjusting uvs to match pixel snapping. (flut…

aee09d9

…ter#162049)" (flutter#162392)" This reverts some of commit d048c77, just the testing parts.

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

gaaclarke added this pull request to the merge queue Jan 30, 2025

Merged via the queue into flutter:master with commit d0d4e96 Jan 30, 2025
177 checks passed

gaaclarke deleted the text-pos-tweak branch January 30, 2025 22:02

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

1f0dcc4

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

18228de

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

49d000d

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

bf395af

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

95c2965

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

8fb9830

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

b8b3c17

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

7bada21

…er/flutter#162351)

gaaclarke mentioned this pull request Feb 11, 2025

[CP] all jittery glyph fixes #163058

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

3530e46

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

0ecd0ce

…er/flutter#162351)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

d0d4e96 Fixed some floating point inaccuracies in TextContents (flutt…

812b202

…er/flutter#162351)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed some floating point inaccuracies in TextContents #162351

Fixed some floating point inaccuracies in TextContents #162351

Uh oh!

gaaclarke commented Jan 28, 2025 •

edited

Loading

Uh oh!

gaaclarke commented Jan 28, 2025

Uh oh!

gaaclarke commented Jan 28, 2025

Uh oh!

gaaclarke Jan 28, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

flutter-dashboard bot commented Jan 29, 2025

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

jonahwilliams commented Jan 29, 2025

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

gaaclarke commented Jan 30, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jan 30, 2025

Uh oh!

Uh oh!

Uh oh!

		glyph_bounds.GetLeftTop() +
		(basis_transform * glyph_position.position);

Fixed some floating point inaccuracies in TextContents #162351

Fixed some floating point inaccuracies in TextContents #162351

Uh oh!

Conversation

gaaclarke commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

before

after

diff

Pre-launch Checklist

Uh oh!

gaaclarke commented Jan 28, 2025

Uh oh!

gaaclarke commented Jan 28, 2025

Uh oh!

gaaclarke Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jan 29, 2025

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

jonahwilliams commented Jan 29, 2025

Uh oh!

gaaclarke commented Jan 29, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

gaaclarke commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Jan 30, 2025

Uh oh!

Uh oh!

Uh oh!

gaaclarke commented Jan 28, 2025 •

edited

Loading

gaaclarke commented Jan 30, 2025 •

edited

Loading