这是indexloc提供的服务，不要输入任何密码
Skip to content

[Android] add lint ignores to Flutter JNI. #162527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2025
Merged

[Android] add lint ignores to Flutter JNI. #162527

merged 2 commits into from
Feb 1, 2025

Conversation

jonahwilliams
Copy link
Contributor

These API calls are triggering lints in g3, which has stricter lints for transitively calling higher API level methods.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Jan 31, 2025
@jtmcdole
Copy link
Member

jtmcdole commented Feb 1, 2025

Cocoon / Luci did not like this:

builder not found: "Windows windows_host_engine_test"

This builder does exist (last week), but I think this needs to be rebased to get it scheduled correctly.

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 1, 2025
Merged via the queue into flutter:master with commit 4d08217 Feb 1, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
f727594 
…62527)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
f95167c 
…62527)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
3ca5d2c 
…62527)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
1e11373 
…62527)
@reidbaker
Copy link
Contributor

Why suppress lint instead of adding @requiresApi? The requires annotation would make sure that this code woudl fail if someone accidentally added api 36 calls.

auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 3, 2025
@engine-flutter-autoroll
Roll Flutter from b007899 to 8e2a6fc (61 revisions) (#8556)
e0fa394 
Roll Flutter from b007899 to 8e2a6fc (61 revisions)

flutter/flutter@b007899...8e2a6fc

2025-02-03 58529443+srujzs@users.noreply.github.com Implement hot reload using the DDC library bundle format (flutter/flutter#162498)
2025-02-01 jonahwilliams@google.com [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527)
2025-02-01 codefu@google.com Fix `Linux docs_publish` running at head (flutter/flutter#162557)
2025-02-01 bdero@google.com [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104)
2025-02-01 jonahwilliams@google.com [Impeller] Increase conical gradient precision. (flutter/flutter#162543)
2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162542)
2025-01-31 1961493+harryterkelsen@users.noreply.github.com [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461)
2025-01-31 mdebbar@google.com [web] Remove HTML build artifacts (flutter/flutter#162528)
2025-01-31 bkonyi@google.com [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522)
2025-01-31 jason-simmons@users.noreply.github.com Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423)
2025-01-31 jason-simmons@users.noreply.github.com [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478)
2025-01-31 15619084+vashworth@users.noreply.github.com Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409)
2025-01-31 yaostyle@gmail.com Fix NavigationRail examples overflow alignment (flutter/flutter#159937)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504)
2025-01-31 tessertaha@gmail.com [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450)
2025-01-31 120297255+PurplePolyhedron@users.noreply.github.com fix syntax error in comment pseudocode (flutter/flutter#162453)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496)
2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162476)
2025-01-31 stuartmorgan@google.com Document flutter/package deps version policy (flutter/flutter#162492)
2025-01-31 magder@google.com Add iOS tool codeowner (flutter/flutter#162167)
2025-01-31 30870216+gaaclarke@users.noreply.github.com Fixed the text aspect ratio (flutter/flutter#162415)
2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494)
2025-01-31 yjbanov@google.com Add new web contributors to web triage doc. (flutter/flutter#162420)
2025-01-30 matanlurey@users.noreply.github.com Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484)
2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474)
2025-01-30 codefu@google.com Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475)
2025-01-30 andrewrkolos@gmail.com Delete `FlutterCommand.usageValues` (flutter/flutter#162468)
2025-01-30 30870216+gaaclarke@users.noreply.github.com Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351)
2025-01-30 mdebbar@google.com Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411)
2025-01-30 bruno.leroux@gmail.com Add FormField.errorBuilder (flutter/flutter#162255)
2025-01-30 tessertaha@gmail.com Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081)
2025-01-30 jonahwilliams@google.com [Android] add HC++ platform view class. (flutter/flutter#161829)
2025-01-30 victorsanniay@gmail.com Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425)
2025-01-30 jonahwilliams@google.com [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454)
2025-01-30 34871572+gmackall@users.noreply.github.com [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835)
2025-01-30 137522957+ChrisCRCB@users.noreply.github.com fix slider semantic label (flutter/flutter#162304)
2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447)
2025-01-30 andrewrkolos@gmail.com Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281)
2025-01-30 andrewrkolos@gmail.com remove more (simple) usage of package:usage (flutter/flutter#162354)
2025-01-30 jonahwilliams@google.com [Android] HC++ plumbing. (flutter/flutter#162407)
2025-01-30 43054281+camsim99@users.noreply.github.com Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828)
2025-01-30 38378650+hgraceb@users.noreply.github.com Fix unexpected shown of Scrollbar (flutter/flutter#159386)
2025-01-30 bkonyi@google.com Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325)
2025-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
efd5db1 
…62527)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
ef9d06a 
…62527)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
4d08217 [Android] add lint ignores to Flutter JNI. (flutter/flutter#1…
2720b71 
…62527)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from b007899 to 8e2a6fc (61 revisions) (flutter#8556)
fa7f75d 
Roll Flutter from b007899 to 8e2a6fc (61 revisions)

flutter/flutter@b007899...8e2a6fc

2025-02-03 58529443+srujzs@users.noreply.github.com Implement hot reload using the DDC library bundle format (flutter/flutter#162498)
2025-02-01 jonahwilliams@google.com [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527)
2025-02-01 codefu@google.com Fix `Linux docs_publish` running at head (flutter/flutter#162557)
2025-02-01 bdero@google.com [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104)
2025-02-01 jonahwilliams@google.com [Impeller] Increase conical gradient precision. (flutter/flutter#162543)
2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162542)
2025-01-31 1961493+harryterkelsen@users.noreply.github.com [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461)
2025-01-31 mdebbar@google.com [web] Remove HTML build artifacts (flutter/flutter#162528)
2025-01-31 bkonyi@google.com [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522)
2025-01-31 jason-simmons@users.noreply.github.com Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423)
2025-01-31 jason-simmons@users.noreply.github.com [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478)
2025-01-31 15619084+vashworth@users.noreply.github.com Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409)
2025-01-31 yaostyle@gmail.com Fix NavigationRail examples overflow alignment (flutter/flutter#159937)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504)
2025-01-31 tessertaha@gmail.com [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450)
2025-01-31 120297255+PurplePolyhedron@users.noreply.github.com fix syntax error in comment pseudocode (flutter/flutter#162453)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496)
2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162476)
2025-01-31 stuartmorgan@google.com Document flutter/package deps version policy (flutter/flutter#162492)
2025-01-31 magder@google.com Add iOS tool codeowner (flutter/flutter#162167)
2025-01-31 30870216+gaaclarke@users.noreply.github.com Fixed the text aspect ratio (flutter/flutter#162415)
2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494)
2025-01-31 yjbanov@google.com Add new web contributors to web triage doc. (flutter/flutter#162420)
2025-01-30 matanlurey@users.noreply.github.com Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484)
2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474)
2025-01-30 codefu@google.com Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475)
2025-01-30 andrewrkolos@gmail.com Delete `FlutterCommand.usageValues` (flutter/flutter#162468)
2025-01-30 30870216+gaaclarke@users.noreply.github.com Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351)
2025-01-30 mdebbar@google.com Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411)
2025-01-30 bruno.leroux@gmail.com Add FormField.errorBuilder (flutter/flutter#162255)
2025-01-30 tessertaha@gmail.com Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081)
2025-01-30 jonahwilliams@google.com [Android] add HC++ platform view class. (flutter/flutter#161829)
2025-01-30 victorsanniay@gmail.com Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425)
2025-01-30 jonahwilliams@google.com [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454)
2025-01-30 34871572+gmackall@users.noreply.github.com [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835)
2025-01-30 137522957+ChrisCRCB@users.noreply.github.com fix slider semantic label (flutter/flutter#162304)
2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447)
2025-01-30 andrewrkolos@gmail.com Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281)
2025-01-30 andrewrkolos@gmail.com remove more (simple) usage of package:usage (flutter/flutter#162354)
2025-01-30 jonahwilliams@google.com [Android] HC++ plumbing. (flutter/flutter#162407)
2025-01-30 43054281+camsim99@users.noreply.github.com Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828)
2025-01-30 38378650+hgraceb@users.noreply.github.com Fix unexpected shown of Scrollbar (flutter/flutter#159386)
2025-01-30 bkonyi@google.com Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325)
2025-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from b007899 to 8e2a6fc (61 revisions) (flutter#8556)
431fc35 
Roll Flutter from b007899 to 8e2a6fc (61 revisions)

flutter/flutter@b007899...8e2a6fc

2025-02-03 58529443+srujzs@users.noreply.github.com Implement hot reload using the DDC library bundle format (flutter/flutter#162498)
2025-02-01 jonahwilliams@google.com [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527)
2025-02-01 codefu@google.com Fix `Linux docs_publish` running at head (flutter/flutter#162557)
2025-02-01 bdero@google.com [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104)
2025-02-01 jonahwilliams@google.com [Impeller] Increase conical gradient precision. (flutter/flutter#162543)
2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162542)
2025-01-31 1961493+harryterkelsen@users.noreply.github.com [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461)
2025-01-31 mdebbar@google.com [web] Remove HTML build artifacts (flutter/flutter#162528)
2025-01-31 bkonyi@google.com [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522)
2025-01-31 jason-simmons@users.noreply.github.com Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423)
2025-01-31 jason-simmons@users.noreply.github.com [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478)
2025-01-31 15619084+vashworth@users.noreply.github.com Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409)
2025-01-31 yaostyle@gmail.com Fix NavigationRail examples overflow alignment (flutter/flutter#159937)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504)
2025-01-31 tessertaha@gmail.com [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450)
2025-01-31 120297255+PurplePolyhedron@users.noreply.github.com fix syntax error in comment pseudocode (flutter/flutter#162453)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502)
2025-01-31 engine-flutter-autoroll@skia.org Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496)
2025-01-31 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162476)
2025-01-31 stuartmorgan@google.com Document flutter/package deps version policy (flutter/flutter#162492)
2025-01-31 magder@google.com Add iOS tool codeowner (flutter/flutter#162167)
2025-01-31 30870216+gaaclarke@users.noreply.github.com Fixed the text aspect ratio (flutter/flutter#162415)
2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494)
2025-01-31 yjbanov@google.com Add new web contributors to web triage doc. (flutter/flutter#162420)
2025-01-30 matanlurey@users.noreply.github.com Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484)
2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474)
2025-01-30 codefu@google.com Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475)
2025-01-30 andrewrkolos@gmail.com Delete `FlutterCommand.usageValues` (flutter/flutter#162468)
2025-01-30 30870216+gaaclarke@users.noreply.github.com Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351)
2025-01-30 mdebbar@google.com Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411)
2025-01-30 bruno.leroux@gmail.com Add FormField.errorBuilder (flutter/flutter#162255)
2025-01-30 tessertaha@gmail.com Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081)
2025-01-30 jonahwilliams@google.com [Android] add HC++ platform view class. (flutter/flutter#161829)
2025-01-30 victorsanniay@gmail.com Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425)
2025-01-30 jonahwilliams@google.com [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454)
2025-01-30 34871572+gmackall@users.noreply.github.com [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835)
2025-01-30 137522957+ChrisCRCB@users.noreply.github.com fix slider semantic label (flutter/flutter#162304)
2025-01-30 engine-flutter-autoroll@skia.org Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447)
2025-01-30 andrewrkolos@gmail.com Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281)
2025-01-30 andrewrkolos@gmail.com remove more (simple) usage of package:usage (flutter/flutter#162354)
2025-01-30 jonahwilliams@google.com [Android] HC++ plumbing. (flutter/flutter#162407)
2025-01-30 43054281+camsim99@users.noreply.github.com Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828)
2025-01-30 38378650+hgraceb@users.noreply.github.com Fix unexpected shown of Scrollbar (flutter/flutter#159386)
2025-01-30 bkonyi@google.com Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325)
2025-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. platform-android Android applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @jtmcdole @reidbaker