[flutter_tools] only copy cached dill after startup #58188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
approved these changes
May 28, 2020
zanderso
reviewed
May 29, 2020
| @@ -434,6 +435,15 @@ class _ResidentWebRunner extends ResidentWebRunner { | |||
| return 1; | |||
| } | |||
| device.generator.accept(); | |||
| globals.logger.printTrace('caching compiled dill...'); | |||
There was a problem hiding this comment.
Instead of duplicated here and in the hot runner, can this be inherited by both from the base class?
zanderso
reviewed
Jun 1, 2020
| trackWidgetCreation: trackWidgetCreation, | ||
| )); | ||
| } | ||
| artifactDirectory.deleteSync(recursive: true); |
There was a problem hiding this comment.
Didn't this deletion pre-exist the cache.dill optimization? Why is it no longer needed?
There was a problem hiding this comment.
since it is a temp dir it gets cleaned up automatically right? Or should we still clean it out manually?
There was a problem hiding this comment.
I'd prefer still making an effort to do manual clean-up. The automatic cleanup doesn't work in all situations, for example if the tool is killed by a signal on Windows after preExit() runs.
There was a problem hiding this comment.
Makes sense, will add it back
jonahwilliams
pushed a commit
that referenced
this pull request
Jun 2, 2020
This reverts commit 39d1e4b.
jonahwilliams
pushed a commit
that referenced
this pull request
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove copying from the shutdown stage since that seems risky (and Android Studio behavior is unlikely to change). If we copy the first compilation we'll still get a decent dill for initialization.
Fixes #58109 (indirectly)