这是indexloc提供的服务，不要输入任何密码
Skip to content

Revert "Revert "[flutter_tools] always initialize the resident runner from di…" #58208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2020
Merged

Revert "Revert "[flutter_tools] always initialize the resident runner from di…" #58208

merged 3 commits into from
May 29, 2020

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 28, 2020 •
edited
Loading

Reverts #58193

Fixes #58250

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 28, 2020
@jonahwilliams jonahwilliams requested a review from zanderso May 28, 2020 23:29
@zanderso
Copy link
Member

Do you want to land this, or just fix the merge conflicts in #58188?

@jonahwilliams
Copy link
Contributor Author

Probably this one first.

@jonahwilliams
Copy link
Contributor Author

Friendly ping @zanderso

jmagman
jmagman approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 6d8ec35 into master May 29, 2020
@fluttergithubbot fluttergithubbot deleted the revert-58193-revert_cache_dill branch May 29, 2020 22:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso zanderso approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linux_chrome_dev_mode SecondStartupTime regression
5 participants
@jonahwilliams @zanderso @jmagman @googlebot @fluttergithubbot