这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dorpvom
Copy link
Member

@dorpvom dorpvom commented Oct 8, 2018

Removed installation details from readme and added a more extensive markdown for installation.
Fixed some deprecated information and added a nicer representation for requirements.

weidenba and others added 30 commits May 28, 2018 13:20
removed file and command for PyQtGraph patch
added filter for decompressing compressed strace data
@dorpvom dorpvom self-assigned this Oct 8, 2018
@dorpvom dorpvom requested a review from weidenba October 8, 2018 15:26
@codecov-io
Copy link

Codecov Report

Merging #162 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   95.79%   95.79%   -0.01%     
==========================================
  Files         309      309              
  Lines       15326    15326              
==========================================
- Hits        14682    14681       -1     
- Misses        644      645       +1
Impacted Files Coverage Δ
...test/integration/scheduler/test_cycle_with_tags.py 98.11% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe2105...fc7f9b4. Read the comment docs.

INSTALL.md Outdated

## TL;DR

0. `(cd path/to/fact/sources && ./pre_install.sh)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path should be "src/bootstrap/pre_install.sh"

The main.cfg on the frontend system has to be altered so that the values of `data_storage.mongo_server` and `data_storage.mongo_port` match the **ip:port** for the database.
The same has to be done for the backend. In addition, since the raw firmware and file binaries are stored in the backend, the `data_storage.firmware_file_storage_directory` has to be created (by default `/media/data/fact_fw_data`).
On the database system, the `mongod.conf` has to be given the correct `net.bindIp` and `net.port`. In addition the path in `storage.dbPath` of the `mongod.conf` has to be created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install options should be explained as well ./install.py [-B -D -F]
Furhtermore we should mention that the databse should be started first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the second request. Starting the database first - or at all - has nothing to do with installation but execution. This should be documented in a getting started page.

@weidenba weidenba merged commit 453bf9d into master Oct 22, 2018
@weidenba weidenba deleted the restructure_readme branch October 22, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants