Sd16 analysis blacklist system #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 95.75% 95.76% +<.01%
==========================================
Files 307 307
Lines 15115 15115
==========================================
+ Hits 14474 14475 +1
+ Misses 641 640 -1
Continue to review full report at Codecov.
|
weidenba
suggested changes
Aug 24, 2018
| <ul> | ||
| <li>Added software components statistics</li> | ||
| <li>Added REST endpoint for binary search (YARA)</li> | ||
| <li>Added unified mime-type-based analysis blacklist feature</li> |
Contributor
There was a problem hiding this comment.
what about the white lists
| {% if firmware.processed_analysis[selected_analysis]['skipped'] %} | ||
| <tr> | ||
| <td class="warning">Analysis was skipped</td> | ||
| <td class="active">Reason: {{ firmware.processed_analysis[selected_analysis]['skipped'] }}</td> |
src/scheduler/Analysis.py
Outdated
| return blacklist, whitelist | ||
|
|
||
| def _get_blacklist_and_whitelist_from_config(self, analysis_plugin: str) -> Tuple[List, List]: | ||
| blacklist = self.config.get(analysis_plugin, 'mime_blacklist', fallback='').split(', ') |
Contributor
There was a problem hiding this comment.
There should be a helper function parsing the list
"a,b" should be as valid as "a, b"
weidenba
approved these changes
Aug 24, 2018
weidenba
pushed a commit
that referenced
this pull request
Oct 22, 2018
Sd16 analysis blacklist system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.