这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: comment aggregation on fw analysis page #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: comment aggregation on fw analysis page #1372

wants to merge 1 commit into from

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented May 23, 2025

  • aggregate comments of included on the firmware's analysis page

part of #1302

@jstucke jstucke self-assigned this May 23, 2025
@jstucke jstucke force-pushed the comment-aggregation branch from 97b60ee to a113f4e Compare May 23, 2025 11:51
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.68%. Comparing base (67fc927) to head (537c187).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/storage/db_interface_frontend.py 83.33% 1 Missing ⚠️
.../test/unit/web_interface/test_app_show_analysis.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
+ Coverage   91.65%   91.68%   +0.02%     
==========================================
  Files         374      374              
  Lines       21048    21081      +33     
==========================================
+ Hits        19292    19328      +36     
+ Misses       1756     1753       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstucke jstucke force-pushed the comment-aggregation branch from a113f4e to 537c187 Compare May 23, 2025 13:48
@jstucke jstucke requested a review from euwint August 1, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint Awaiting requested review from euwint

At least 1 approving review is required to merge this pull request.

Assignees

@jstucke jstucke

Labels

feature gui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jstucke @codecov-commenter