这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: converted software components plugin to new base class #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

feat: converted software components plugin to new base class #1332

merged 1 commit into from
Jun 18, 2025

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Jan 22, 2025 •
edited
Loading

also adjusted known_vuln. and cve_lookup plugins to work with the new result structure

@jstucke jstucke self-assigned this Jan 22, 2025
@jstucke jstucke force-pushed the software-components-v1 branch 2 times, most recently from 1de54ba to 913fd86 Compare January 22, 2025 12:09
@dorpvom dorpvom self-requested a review January 23, 2025 10:02
@jstucke jstucke force-pushed the software-components-v1 branch from 913fd86 to 0785fc3 Compare January 23, 2025 10:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.30201% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (466d9ba) to head (2b9570b).

Files with missing lines Patch % Lines
...is/software_components/code/software_components.py 91.46% 7 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1332   +/-   ##
=======================================
  Coverage   91.59%   91.60%           
=======================================
  Files         374      374           
  Lines       21032    21045   +13     
=======================================
+ Hits        19265    19278   +13     
  Misses       1767     1767

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maringuu maringuu self-requested a review January 29, 2025 10:41
@jstucke jstucke force-pushed the software-components-v1 branch from 0785fc3 to 9a70a89 Compare June 17, 2025 07:31
@jstucke
feat: converted software components plugin to new base class
2b9570b 
also adjusted known_vuln. and cve_lookup plugins to work with the new result structure
@jstucke jstucke force-pushed the software-components-v1 branch from 9a70a89 to 2b9570b Compare June 17, 2025 12:46
euwint
euwint approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine

@euwint euwint merged commit 9df6469 into master Jun 18, 2025
8 checks passed
@euwint euwint deleted the software-components-v1 branch June 18, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint euwint approved these changes

@dorpvom dorpvom Awaiting requested review from dorpvom

@maringuu maringuu Awaiting requested review from maringuu

Assignees

@jstucke jstucke

Labels

in progress refactoring

Projects

None yet

Milestone

Convert all analysis plugins to new b...

Development

Successfully merging this pull request may close these issues.

5 participants

@jstucke @codecov-commenter @euwint @dorpvom