Yara python fix #1330
Merged
Yara python fix #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstucke
commented
Jan 20, 2025
- install yara-python from source
- Why ist this necessary? Plugins like software_components need support for YARA modules (especially magic) and the pre-built version of yara-python from PyPI does not include this
- moved get_yara_error method to backend (intercom)
- having the method in the frontend does not make a lot of sense, because the yara version of the backend could be different and compiling the rules could still fail
700adca to
083dea8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
- Coverage 92.50% 91.84% -0.67%
==========================================
Files 381 376 -5
Lines 24219 21056 -3163
==========================================
- Hits 22404 19338 -3066
+ Misses 1815 1718 -97 ☔ View full report in Codecov by Sentry. |
083dea8 to
a33f3ee
Compare
Why ist this necessary? Plugins like software_components need support for YARA modules and the pre-built version of yara-python from PyPI does not include this.
having the method in the frontend does not make a lot of sense, because the yara version of the backend could be different and compiling the rules could still fail
a33f3ee to
5d831b8
Compare
1 task
dorpvom
approved these changes
Jan 22, 2025
Fukulngx1
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.