fix: resolve Yarn PnP compatibility issues with client bundle generation #2401
Conversation
Replace fs.cpSync with PnP-compatible recursive copy function to fix file copying from ZIP archives in Yarn PnP environments. - Add copyRecursivePnP() function using fs.readFile/writeFile operations - Replace all fs.cpSync calls in generateClientBundle() - Maintain createRequire() for package root resolution - Fix ENOENT errors when accessing /dist/clients/core in PnP Fixes hey-api#2237, hey-api#2183
|
|
|
@mrclrchtr is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 42566ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I created a local npm registry setup with After this fix the error was gone. Unfortunately I don't know exactly, if there are some side effects. |
| copyRecursivePnP(path.join(src, file), path.join(dest, file)); | ||
| } | ||
| } else { | ||
| const content = fs.readFileSync(src); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
==========================================
- Coverage 22.46% 22.46% -0.01%
==========================================
Files 324 324
Lines 31956 31971 +15
Branches 1234 1234
==========================================
+ Hits 7179 7181 +2
- Misses 24768 24781 +13
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrlubos
left a comment
There was a problem hiding this comment.
This is wild. How long did it take you to debug? Tests are passing so I guess it works. Let's release it and find out 🤠 is there any test we could add that would be failing without these changes?
|
I'll be honest, I wouldn't have figured that out without AI. But it really didn't do badly on that topic. I think a test would be very difficult to set up... you would have to do the test with yarn PnP somehow... I don't know how to do that. |
|
Hey, as long as it works 👯 |
Replace fs.cpSync with PnP-compatible recursive copy function to fix file copying from ZIP archives in Yarn PnP environments.
Fixes #2237, #2183