这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@flow96
Copy link
Contributor

@flow96 flow96 commented Aug 8, 2025

Fixes #2377

There is an issue a recursion issue when the schema contains a Tag and an operationId that are "normalized" to the same result e.g. "TodoItem".
This only happens when asClassis set to true

…d the schema contains a tag and an operationId with the same name (e.g. "TodoItem")
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2025

🦋 Changeset detected

Latest commit: 9704055

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 8, 2025

@flow96 is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug 🔥 Something isn't working labels Aug 8, 2025
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 22.46%. Comparing base (e1d8a56) to head (9704055).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2407   +/-   ##
=======================================
  Coverage   22.46%   22.46%           
=======================================
  Files         324      324           
  Lines       31971    31971           
  Branches     1234     1234           
=======================================
  Hits         7181     7181           
  Misses      24781    24781           
  Partials        9        9           
Flag Coverage Δ
unittests 22.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2407
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2407
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2407

commit: 9704055

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2025
@mrlubos mrlubos merged commit a650513 into hey-api:main Aug 8, 2025
14 of 16 checks passed
@flow96 flow96 deleted the fix/recursion-issue-tag-and-operationid branch August 13, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded when using asClass: true

2 participants