-
-
Notifications
You must be signed in to change notification settings - Fork 272
fix: add a check to prevent a recursion issue when asClass is true and the schema contains a tag and an operationId with the same name (e.g. "TodoItem") #2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d the schema contains a tag and an operationId with the same name (e.g. "TodoItem")
|
|
🦋 Changeset detectedLatest commit: 9704055 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@flow96 is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
=======================================
Coverage 22.46% 22.46%
=======================================
Files 324 324
Lines 31971 31971
Branches 1234 1234
=======================================
Hits 7181 7181
Misses 24781 24781
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commit: |
mrlubos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – thank you!
Fixes #2377
There is an issue a recursion issue when the schema contains a Tag and an operationId that are "normalized" to the same result e.g. "TodoItem".
This only happens when
asClassis set totrue