hasura · hallettj · Mar 10, 2025 · Mar 5, 2025 · Mar 7, 2025 · Mar 7, 2025
diff --git a/.cargo/audit.toml b/.cargo/audit.toml
@@ -0,0 +1,4 @@
+[advisories]
+ignore = [
+  "RUSTSEC-2024-0437" # in protobuf via prometheus, but we're not using proto so it shouldn't be an issue
+]
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -30,11 +30,24 @@ jobs:
       - name: run linter checks with clippy 🔨
         run: nix build .#checks.x86_64-linux.lint --print-build-logs
 
-      - name: update rust-sec advisory db before scanning for vulnerabilities
-        run: nix flake lock --update-input advisory-db
-
-      - name: audit for reported security problems 🔨
-        run: nix build .#checks.x86_64-linux.audit --print-build-logs
-
       - name: run integration tests 📋
         run: nix develop --command just test-mongodb-versions
+
+  audit:
+    name: Security Audit
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout 🛎️
+        uses: actions/checkout@v3
+
+      - name: Install Nix ❄
+        uses: DeterminateSystems/nix-installer-action@v4
+
+      - name: Link Cachix 🔌
+        uses: cachix/cachix-action@v12
+        with:
+          name: '${{ vars.CACHIX_CACHE_NAME }}'
+          authToken: '${{ secrets.CACHIX_CACHE_AUTH_TOKEN }}'
+
+      - name: audit for reported security problems 🔨
+        run: nix develop --command cargo audit
diff --git a/.gitignore b/.gitignore
@@ -3,6 +3,9 @@
 debug/
 target/
 
+.cargo/*
+!.cargo/audit.toml
+
 # These are backup files generated by rustfmt
 **/*.rs.bk
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,10 +8,31 @@ This changelog documents the changes between release versions.
 
 - Add uuid scalar type ([#148](https://github.com/hasura/ndc-mongodb/pull/148))
 
+### Changed
+
+- On database introspection newly-added collection fields will be added to existing schema configurations ([#152](https://github.com/hasura/ndc-mongodb/pull/152))
+
 ### Fixed
 
 - Update dependencies to get fixes for reported security vulnerabilities ([#149](https://github.com/hasura/ndc-mongodb/pull/149))
 
+#### Changes to database introspection
+
+Previously running introspection would not update existing schema definitions, it would only add definitions for
+newly-added collections. This release changes that behavior to make conservative changes to existing definitions: 
+
+- added fields, either top-level or nested, will be added to existing schema definitions
+- types for fields that are already configured will **not** be changed automatically
+- fields that appear to have been added to collections will **not** be removed from configurations
+
+We take such a conservative approach to schema configuration changes because we want to avoid accidental breaking API
+changes, and because schema configuration can be edited by hand, and we don't want to accidentally reverse such
+modifications.
+
+If you want to make type changes to fields that are already configured, or if you want to remove fields from schema
+configuration you can either make those edits to schema configurations by hand, or you can delete schema files before
+running introspection.
+
 #### UUID scalar type
 
 Previously UUID values would show up in GraphQL as `BinData`. BinData is a generalized BSON type for binary data. It

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/cli/Cargo.toml b/crates/cli/Cargo.toml
@@ -19,6 +19,7 @@ enum-iterator = "^2.0.0"
 futures-util = "0.3.28"
 indexmap = { workspace = true }
 itertools = { workspace = true }
+json-structural-diff = "^0.2.0"
 ndc-models = { workspace = true }
 nom = { version = "^7.1.3", optional = true }
 nonempty = "^0.10.0"
@@ -35,7 +36,8 @@ tokio = { version = "1.36.0", features = ["full"] }
 mongodb-agent-common = { path = "../mongodb-agent-common", features = ["test-helpers"] }
 
 async-tempfile = "^0.6.0"
-googletest = "^0.12.0"
+googletest = "^0.13.0"
 pretty_assertions = "1"
 proptest = "1"
+ndc-test-helpers = { path = "../ndc-test-helpers" }
 test-helpers = { path = "../test-helpers" }