-
Notifications
You must be signed in to change notification settings - Fork 3
introspection updates existing schemas to add fields only #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hallettj
merged 10 commits into
v1
from
jessehallett/eng-965-connector-introspection-enhancements
Mar 10, 2025
Merged
introspection updates existing schemas to add fields only #152
hallettj
merged 10 commits into
v1
from
jessehallett/eng-965-connector-introspection-enhancements
Mar 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eprintln!("Warning: introspection detected some changes to to database thate were **not** applied to existing | ||
schema configurations. To avoid accidental breaking changes the introspection system is | ||
conservative about what changes are applied automatically."); | ||
eprintln!(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all extremely explicit about what is going on, which is excellent.
danieljharvey
approved these changes
Mar 10, 2025
Co-authored-by: Daniel Harvey <danieljamesharvey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running introspection would not update existing schema definitions, it would only add definitions for newly-added collections. This PR changes that behavior to make conservative changes to existing definitions: added fields, either top-level or nested, will be added to existing schema definitions. Types for fields that are already configured will not be changed. Fields that appear to have been added to collections will not be removed from configurations.
I included output that shows any detected database changes that were not applied to configuration. Here's what that looks like: