-
Notifications
You must be signed in to change notification settings - Fork 2.8k
server: customize tracking tables with a custom name #5719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 40 commits into
hasura:master
from
codingkarthik:custom-table-identifier
Oct 29, 2020
Merged
server: customize tracking tables with a custom name #5719
kodiakhq
merged 40 commits into
hasura:master
from
codingkarthik:custom-table-identifier
Oct 29, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit f4f0d18 |
a0d60ac to
1f28be6
Compare
marionschleifer
previously requested changes
Sep 14, 2020
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
docs/graphql/core/api-reference/schema-metadata-api/table-view.rst
Outdated
Show resolved
Hide resolved
….rst Co-authored-by: Marion Schleifer <marion@hasura.io>
….rst Co-authored-by: Marion Schleifer <marion@hasura.io>
….rst Co-authored-by: Marion Schleifer <marion@hasura.io>
….rst Co-authored-by: Marion Schleifer <marion@hasura.io>
- rename set_table_configuration to set_table_customization - rename identifier to custom_name
1475a5d to
8fc740d
Compare
0x777
approved these changes
Oct 29, 2020
0x777
approved these changes
Oct 29, 2020
Member
0x777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tirumaraiselvan
approved these changes
Oct 29, 2020
stale
marionschleifer
approved these changes
Oct 29, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of custom table identifiers. An identifier is an alias for a table. When a table is tracked with an identifier, the nodes generated for the table will be according to the identifier. The identifier can be useful to use when
tracking tables with non GraphQL compliant names or it can be useful if the nodes that are generated should not be dependent on the table name i.e when a table is tracked with an identifier and if the table has been renamed, the node names will not be changed due to the identifier.
Description
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Solution and Design
fixes #3811
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sqlauto manages the new metadata through schema diffing?run_sqlauto manages the definitions of metadata on renaming?export_metadata/replace_metadatasupports the new metadata added?GraphQL
Breaking changes
No Breaking changes
There are breaking changes:
Metadata API
Existing
querytypes:argspayload which is not backward compatibleJSONschemaGraphQL API
Schema Generation:
If a table has an identifier set, then the types and names are generated according to the identifier.
Schema Resolve:-
nullvalue for any input fieldsLogging
JSONschema has changedtypenames have changedLIMITATIONS:
To be able to track a table, the constraint names should be GraphQL compliant, otherwise the table cannot be tracked.