这是indexloc提供的服务，不要输入任何密码
Skip to content

console: misc updates #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2020
Merged

console: misc updates #5488

merged 3 commits into from
Jul 30, 2020

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Jul 30, 2020 •
edited
Loading

Description

  • Data triggers -> Event triggers (making this consistent with docs)
  • Add Know more links to descriptions
  • move sidebarIcon selecting logic from common component
  • "search data/cron" -> "search triggers" in sidebar

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk requested a review from a team as a code owner July 30, 2020 14:19
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit 6c2e477 deployed to Heroku: https://hge-ci-pull-5488.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5488-6c2e4772

@rikinsk rikinsk requested a review from tirumaraiselvan July 30, 2020 15:35
tirumaraiselvan
tirumaraiselvan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit 5611292 deployed to Heroku: https://hge-ci-pull-5488.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5488-5611292a

@beerose beerose merged commit 7045fff into hasura:master Jul 30, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app https://hge-ci-pull-5488.herokuapp.com is deleted

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jul 31, 2020
@rikinsk
console: misc updates (hasura#5488)
f30e596
@beerose beerose mentioned this pull request Jul 31, 2020
Merged
rikinsk pushed a commit that referenced this pull request Jul 31, 2020
console: misc updates (#5484, #5488, #5486, #5481, #5252) (#5496)
9694a3a
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@rikinsk @stevefan1999-personal
console: misc updates (hasura#5488)
8b1a6da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console no-changelog-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk @hasura-bot @tirumaraiselvan @beerose