这是indexloc提供的服务，不要输入任何密码
Skip to content

console: fix telemetry #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 30, 2020
Merged

console: fix telemetry #5484

merged 5 commits into from
Jul 30, 2020

Conversation

@rikinsk
Copy link
Member

@rikinsk rikinsk commented Jul 30, 2020 •
edited
Loading

Description

  • fix tracking of events and actions urls
  • track all urls (currently '/' was returned for urls not explicitly matched)
  • refactor regexes

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk requested a review from a team as a code owner July 30, 2020 11:55
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit 2c8f574 deployed to Heroku: https://hge-ci-pull-5484.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5484-2c8f5742

beerose
beerose reviewed Jul 30, 2020
View reviewed changes
@rikinsk rikinsk requested a review from beerose July 30, 2020 14:59
beerose
beerose approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console code

@beerose beerose requested a review from tirumaraiselvan July 30, 2020 15:28
tirumaraiselvan
tirumaraiselvan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changelog required

@rikinsk rikinsk merged commit 8194494 into hasura:master Jul 30, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app https://hge-ci-pull-5484.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-telemetry-fix branch July 30, 2020 15:35
beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jul 31, 2020
@rikinsk
console: fix telemetry (hasura#5484)
5c0fbff
@beerose beerose mentioned this pull request Jul 31, 2020
Merged
rikinsk pushed a commit that referenced this pull request Jul 31, 2020
console: misc updates (#5484, #5488, #5486, #5481, #5252) (#5496)
9694a3a
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@rikinsk @stevefan1999-personal
console: fix telemetry (hasura#5484)
b5b3ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console no-changelog-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rikinsk @hasura-bot @tirumaraiselvan @beerose