这是indexloc提供的服务，不要输入任何密码
Skip to content

console: handle nested fragments in allowed queries (close #5137) #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 31, 2020
Merged

console: handle nested fragments in allowed queries (close #5137) #5252

merged 7 commits into from
Jul 31, 2020

Conversation

@ShahAnuj2610
Copy link
Contributor

@ShahAnuj2610 ShahAnuj2610 commented Jul 1, 2020 •
edited
Loading

close #5137

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Console

Solution and Design

  • include fragments recursively for FragmentSpread kind

Steps to test and verify

tried with this nested query and it works

fragment NestedAddress on nested_address {
	address_line_1
	address_line_2
}


fragment Address on addresses {
  street
  state
  zip
	nested_address {
		...NestedAddress
	}
}

fragment User on users {
  id
  name
  address_1 {
    ...Address
  }
  address_2 {
    ...Address
  }
}
                                
query UsersQuery {
  users {
    ...User
  }
}

@ShahAnuj2610 ShahAnuj2610 requested a review from a team as a code owner July 1, 2020 10:42
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Beep boop! 🤖

Hey @ShahAnuj2610, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@netlify
Copy link

netlify bot commented Jul 1, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 31cd422

https://deploy-preview-5252--hasura-docs.netlify.app

@ShahAnuj2610 ShahAnuj2610 requested a review from a team as a code owner July 1, 2020 10:45
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 1, 2020

Review app for commit 26b5f33 deployed to Heroku: https://hge-ci-pull-5252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5252-26b5f33e

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit 22f3265 deployed to Heroku: https://hge-ci-pull-5252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5252-22f3265a

@beerose beerose changed the title console: fix allowed queries through upload graphql file (close #5137) console: handle nested fragments in allowed queries (close #5137) Jul 30, 2020
beerose
beerose approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Approving console changes.

@beerose beerose requested a review from rikinsk July 30, 2020 08:39
@beerose beerose assigned rikinsk and unassigned beerose Jul 30, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 30, 2020

Review app for commit ca0fa50 deployed to Heroku: https://hge-ci-pull-5252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5252-ca0fa506

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2020

Review app for commit bbe4379 deployed to Heroku: https://hge-ci-pull-5252.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5252-bbe4379c

@beerose beerose merged commit 65e568e into hasura:master Jul 31, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2020

Beep boop! 🤖

GIF

Awesome work @ShahAnuj2610! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

hasura-bot commented Jul 31, 2020

Review app https://hge-ci-pull-5252.herokuapp.com is deleted

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jul 31, 2020
@ShahAnuj2610
console: handle nested fragments in allowed queries (close hasura#5137)…
c233a16 
… (hasura#5252)
@beerose beerose mentioned this pull request Jul 31, 2020
Merged
rikinsk pushed a commit that referenced this pull request Jul 31, 2020
console: misc updates (#5484, #5488, #5486, #5481, #5252) (#5496)
9694a3a
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@ShahAnuj2610 @stevefan1999-personal
console: handle nested fragments in allowed queries (close hasura#5137)…
5a89fdd 
… (hasura#5252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikinsk rikinsk

Labels

c/console Related to console community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allowed queries "Upload graphql file" button does not include nested fragments

5 participants

@ShahAnuj2610 @hasura-bot @beerose @rikinsk @marionschleifer